You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/01 16:45:56 UTC

[GitHub] [incubator-pekko-connectors] mdedetrich opened a new issue, #89: Rename get* Java methods which return boolean to is*

mdedetrich opened a new issue, #89:
URL: https://github.com/apache/incubator-pekko-connectors/issues/89

   Its more idiomatic in Java for getters for methods that return Boolean to use `isField` rather than `getField`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning commented on issue #89: Rename get* Java methods which return boolean to is*

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #89:
URL: https://github.com/apache/incubator-pekko-connectors/issues/89#issuecomment-1531958756

   @mdedetrich I'm happy to close this if the pre-existing norm in Akka/Pekko is to use names like 'getBucketVersioningEnabled'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on issue #89: Rename get* Java methods which return boolean to is*

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #89:
URL: https://github.com/apache/incubator-pekko-connectors/issues/89#issuecomment-1531960383

   I don't have an problem with the premise of the issue as its trivial to resolve (i.e. make new methods and deprecate old ones) and its a nice improvement so we can leave the issue open


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org