You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Ralf Hauser (JIRA)" <ji...@apache.org> on 2007/08/17 15:02:34 UTC
[jira] Created: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
--------------------------------------------------------------------------------------------
Key: STR-3086
URL: https://issues.apache.org/struts/browse/STR-3086
Project: Struts 1
Issue Type: Improvement
Affects Versions: 1.3.8
Environment: any
Reporter: Ralf Hauser
we use the redirect approach and for that we store the error messages in the session.
Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41931 ]
Paul Benedict commented on STR-3086:
------------------------------------
The issue is most likely caused by you using the classic RequestProcessor. This does not remove messages from the session. Switch to the ComposableRequestProcessor for the behavior you desire. I do wonder, however, if this feature should be copied to the classic RequestProcessor....
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on STR-3086 started by Ralf Hauser.
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41927 ]
Paul Benedict commented on STR-3086:
------------------------------------
Are you sure you're putting the messages in the session? doErrorsExist() eventually calls TagUtils.getInstance().getActionMessages() which checks all scopes.
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Paul Benedict
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41933 ]
Paul Benedict commented on STR-3086:
------------------------------------
Since Struts 1.2, the processCachedMessages has been part of the classic RequestProcessor. Please see that. Messages must be marked as "accessed" for them to be removed.
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41928 ]
Ralf Hauser commented on STR-3086:
----------------------------------
Apologies. My fault. If the errors are in the session, they must be removed after viewing them with <my:errors />.
now not only removing them but storing them under an errorKey="xyz_previous" and then it should work with the existing doErrorsExist.
Apparently can't do that myself, therefore pls set RFE status to "invalid".
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3086:
-------------------------------
Fix Version/s: (was: 1.3.10)
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3086:
-------------------------------
Fix Version/s: 1.3.10
Assignee: Paul Benedict
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Paul Benedict
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ralf Hauser updated STR-3086:
-----------------------------
Description:
we use the redirect approach and for that we store the error messages in the session.
Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
was:
we use the redirect approach and for that we store the error messages in the session.
Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict closed STR-3086.
------------------------------
Resolution: Won't Fix
Closing based on reporter's request.
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41929 ]
Paul Benedict commented on STR-3086:
------------------------------------
Is <my:errors /> a custom tag of yours? I am a bit confused :-) I will mark this as INVALID if you're sure there's not a bug or enhancement request for Struts.
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Ralf Hauser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ralf Hauser reassigned STR-3086:
--------------------------------
Assignee: Ralf Hauser (was: Paul Benedict)
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
> Fix For: 1.3.10
>
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-3086) doErrorsExist() needs to get
ActionMessages errors also from the session if redirect is used
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-3086:
-------------------------------
Comment: was deleted
> doErrorsExist() needs to get ActionMessages errors also from the session if redirect is used
> --------------------------------------------------------------------------------------------
>
> Key: STR-3086
> URL: https://issues.apache.org/struts/browse/STR-3086
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.3.8
> Environment: any
> Reporter: Ralf Hauser
> Assignee: Ralf Hauser
>
> we use the redirect approach and for that we store the error messages in the session.
> Unfortunately, error tags as per http://www.niallp.pwp.blueyonder.co.uk/strutshighlight.html will not be found.
> There should be a way to tell the tags that it should also look for the errorKey in the HttpSession since we use redirect in the forward declarations of the struts-config.xml
> overwriting org.apache.struts.taglib.html.BaseHandlerTag.doErrorsExist() works, but is cumbersome
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.