[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

[GitBox <gi...@apache.org>]

slfan1989 commented on code in PR #4435:
URL: https://github.com/apache/hadoop/pull/4435#discussion_r1055407270


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java:
##########
@@ -996,6 +996,22 @@ public void run() {
     @Override
     public void run() {
       while (true) {
+        if (futures.isEmpty()) {
+          synchronized (this) {
+            try {
+              // waiting for tokenRenewerThreadTimeout milliseconds
+              long waitingTimeMs = Math.min(10000, Math.max(500, tokenRenewerThreadTimeout));

Review Comment:
   500, 10000 Should we increase the configuration？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org