You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/18 12:54:56 UTC
[GitHub] [flink] godfreyhe opened a new pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
godfreyhe opened a new pull request #14428:
URL: https://github.com/apache/flink/pull/14428
## What is the purpose of the change
*Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan*
## Brief change log
- *Introduce StreamPhysicalDataStreamScan, and make StreamExecDataStreamScan only extended from ExecNode*
- *Introduce BatchPhysicalDataStreamScan, and make BatchExecDataStreamScan only extended from ExecNode*
## Verifying this change
This change is a refactoring rework covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
}, {
"hash" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0f530a305a0d33557eedf91715ad8e4ac2604cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081)
* 18b85ad3b3f803a13ad8239a039b57101a002d7f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748070275
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c8d5bac964a6dd973db3e643118f4af50c82f7a5 (Fri Dec 18 12:56:38 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
}, {
"hash" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094",
"triggerID" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0f530a305a0d33557eedf91715ad8e4ac2604cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081)
* 18b85ad3b3f803a13ad8239a039b57101a002d7f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5bac964a6dd973db3e643118f4af50c82f7a5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040)
* e0f530a305a0d33557eedf91715ad8e4ac2604cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5bac964a6dd973db3e643118f4af50c82f7a5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5bac964a6dd973db3e643118f4af50c82f7a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
}, {
"hash" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094",
"triggerID" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"triggerType" : "PUSH"
}, {
"hash" : "090c3d8e7f458088671fa968f017d815d69af900",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11123",
"triggerID" : "090c3d8e7f458088671fa968f017d815d69af900",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 090c3d8e7f458088671fa968f017d815d69af900 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11123)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14428:
URL: https://github.com/apache/flink/pull/14428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14428:
URL: https://github.com/apache/flink/pull/14428#discussion_r546693762
##########
File path: flink-table/flink-table-planner-blink/src/test/resources/explain/testStatementSetExecutionExplain.out
##########
@@ -32,9 +32,9 @@ LegacySink(name=[`default_catalog`.`default_database`.`MySink`], fields=[first])
} ]
}, {
"id" : ,
- "type" : "SourceConversion(table=[default_catalog.default_database.MyTable, source: [CsvTableSource(read fields: last)]], fields=[last])",
+ "type" : "SourceConversionToRowData",
"pact" : "Operator",
- "contents" : "SourceConversion(table=[default_catalog.default_database.MyTable, source: [CsvTableSource(read fields: last)]], fields=[last])",
+ "contents" : "SourceConversionToRowData",
Review comment:
revert the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0f530a305a0d33557eedf91715ad8e4ac2604cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5bac964a6dd973db3e643118f4af50c82f7a5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040)
* e0f530a305a0d33557eedf91715ad8e4ac2604cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c8d5bac964a6dd973db3e643118f4af50c82f7a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
}, {
"hash" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094",
"triggerID" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"triggerType" : "PUSH"
}, {
"hash" : "090c3d8e7f458088671fa968f017d815d69af900",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "090c3d8e7f458088671fa968f017d815d69af900",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18b85ad3b3f803a13ad8239a039b57101a002d7f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094)
* 090c3d8e7f458088671fa968f017d815d69af900 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14428:
URL: https://github.com/apache/flink/pull/14428#discussion_r546598135
##########
File path: flink-table/flink-table-planner-blink/src/test/resources/explain/testStatementSetExecutionExplain.out
##########
@@ -32,9 +32,9 @@ LegacySink(name=[`default_catalog`.`default_database`.`MySink`], fields=[first])
} ]
}, {
"id" : ,
- "type" : "SourceConversion(table=[default_catalog.default_database.MyTable, source: [CsvTableSource(read fields: last)]], fields=[last])",
+ "type" : "SourceConversionToRowData",
"pact" : "Operator",
- "contents" : "SourceConversion(table=[default_catalog.default_database.MyTable, source: [CsvTableSource(read fields: last)]], fields=[last])",
+ "contents" : "SourceConversionToRowData",
Review comment:
the same as the pr before, it would be better to have the info of table in operator name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
}, {
"hash" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094",
"triggerID" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18b85ad3b3f803a13ad8239a039b57101a002d7f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-748082099
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11040",
"triggerID" : "c8d5bac964a6dd973db3e643118f4af50c82f7a5",
"triggerType" : "PUSH"
}, {
"hash" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11081",
"triggerID" : "e0f530a305a0d33557eedf91715ad8e4ac2604cc",
"triggerType" : "PUSH"
}, {
"hash" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094",
"triggerID" : "18b85ad3b3f803a13ad8239a039b57101a002d7f",
"triggerType" : "PUSH"
}, {
"hash" : "090c3d8e7f458088671fa968f017d815d69af900",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11123",
"triggerID" : "090c3d8e7f458088671fa968f017d815d69af900",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18b85ad3b3f803a13ad8239a039b57101a002d7f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11094)
* 090c3d8e7f458088671fa968f017d815d69af900 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11123)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14428: [FLINK-20609][table-planner-blink] Separate the implementation of BatchExecDataStreamScan and StreamExecDataStreamScan
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14428:
URL: https://github.com/apache/flink/pull/14428#issuecomment-749304203
The failures are unstable cases, there is an [issue](https://issues.apache.org/jira/browse/FLINK-20703) to track it, I will resolve the conflicts offline and merge this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org