[GitHub] [hudi] xushiyan commented on a diff in pull request #5920: [HUDI-4326] add updateTableSerDeInfo for HiveSyncTool

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #5920:
URL: https://github.com/apache/hudi/pull/5920#discussion_r974843935


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveSyncClient.java:
##########
@@ -316,4 +353,11 @@ public void updateTableComments(String tableName, List<FieldSchema> fromMetastor
     }
   }
 
+  Table getTable(String tableName) {
+    try {
+      return client.getTable(databaseName, tableName);
+    } catch (TException e) {
+      throw new HoodieHiveSyncException(String.format("Database: %s, Table: %s  does not exist", databaseName, tableName), e);
+    }
+  }

Review Comment:
   where do we use this method? other methods from this class just call client.getTable(). we should not introduce random helpers that lowers the code quality



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org