You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Peter Lawrey (JIRA)" <ji...@apache.org> on 2009/01/18 13:04:59 UTC
[jira] Created: (COLLECTIONS-312) Minor changes to tidy modifiers
for fields, methods and classes.
Minor changes to tidy modifiers for fields, methods and classes.
----------------------------------------------------------------
Key: COLLECTIONS-312
URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
Project: Commons Collections
Issue Type: Improvement
Reporter: Peter Lawrey
Priority: Trivial
Attachments: commons-collections-static-analysis.patch
These changes include
- private/package-local fields final if possible.
- private/package-local methods and classes static if possible
- remove fields which can be make local variables.
See the attached patch for the changes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-312) Minor changes to tidy modifiers
for fields, methods and classes.
Posted by "Peter Lawrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Lawrey updated COLLECTIONS-312:
-------------------------------------
Attachment: commons-collections-static-analysis.patch
Patch file of changes.
> Minor changes to tidy modifiers for fields, methods and classes.
> ----------------------------------------------------------------
>
> Key: COLLECTIONS-312
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Attachments: commons-collections-static-analysis.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> These changes include
> - private/package-local fields final if possible.
> - private/package-local methods and classes static if possible
> - remove fields which can be make local variables.
> See the attached patch for the changes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-312) Minor changes to tidy modifiers
for fields, methods and classes.
Posted by "Peter Lawrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Lawrey updated COLLECTIONS-312:
-------------------------------------
Attachment: (was: commons-collections-static-analysis.patch)
> Minor changes to tidy modifiers for fields, methods and classes.
> ----------------------------------------------------------------
>
> Key: COLLECTIONS-312
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Attachments: commons-collections-static-analysis.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> These changes include
> - private/package-local fields final if possible.
> - private/package-local methods and classes static if possible
> - remove fields which can be make local variables.
> See the attached patch for the changes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-312) Minor changes to tidy modifiers
for fields, methods and classes.
Posted by "Peter Lawrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Lawrey updated COLLECTIONS-312:
-------------------------------------
Attachment: commons-collections-static-analysis.patch
> Minor changes to tidy modifiers for fields, methods and classes.
> ----------------------------------------------------------------
>
> Key: COLLECTIONS-312
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Attachments: commons-collections-static-analysis.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> These changes include
> - private/package-local fields final if possible.
> - private/package-local methods and classes static if possible
> - remove fields which can be make local variables.
> See the attached patch for the changes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COLLECTIONS-312) Minor changes to tidy modifiers
for fields, methods and classes.
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880545#action_12880545 ]
Henri Yandell commented on COLLECTIONS-312:
-------------------------------------------
Thanks Peter.
Patches weren't applying too cleanly after the merge from 4.0, so I've applied some by hand and still have 1200 lines to go through.
> Minor changes to tidy modifiers for fields, methods and classes.
> ----------------------------------------------------------------
>
> Key: COLLECTIONS-312
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Attachments: commons-collections-static-analysis.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> These changes include
> - private/package-local fields final if possible.
> - private/package-local methods and classes static if possible
> - remove fields which can be make local variables.
> See the attached patch for the changes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.