You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/07/28 00:11:35 UTC
Review Request 36862: Added metric for number of preempted executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-3159
https://issues.apache.org/jira/browse/MESOS-3159
Repository: mesos
Description
-------
We should keep track of how many containers/executors has been
destroyed/killed due to preemption (due to QoS corrections).
Diffs
-----
src/slave/metrics.hpp 43c8662a211266f358772e55eef374462cb971a0
src/slave/metrics.cpp ae3a53e8ac2e8e76a6a77fdc7ba55ccaae00781a
src/slave/slave.cpp 16c403b3ff506461f3dadcfb9f6ee5e66eccb5d7
src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
src/tests/slave_tests.cpp e086817a980cf88f8ff8d539e9791051f35dfbac
Diff: https://reviews.apache.org/r/36862/diff/
Testing
-------
Thanks,
Niklas Nielsen
Re: Review Request 36862: Added metric for number of preempted
executors.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/#review93196
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36862]
All tests passed.
- Mesos ReviewBot
On July 27, 2015, 10:30 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36862/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3159
> https://issues.apache.org/jira/browse/MESOS-3159
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We should keep track of how many containers/executors has been
> destroyed/killed due to preemption (due to QoS corrections).
>
>
> Diffs
> -----
>
> src/slave/metrics.hpp 43c8662a211266f358772e55eef374462cb971a0
> src/slave/metrics.cpp ae3a53e8ac2e8e76a6a77fdc7ba55ccaae00781a
> src/slave/slave.cpp 16c403b3ff506461f3dadcfb9f6ee5e66eccb5d7
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
> src/tests/slave_tests.cpp e086817a980cf88f8ff8d539e9791051f35dfbac
>
> Diff: https://reviews.apache.org/r/36862/diff/
>
>
> Testing
> -------
>
> make check with new checks in OversubscriptionTest.QoSCorrectionKill
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 36862: Added metric for number of preempted
executors.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/#review93197
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 27, 2015, 10:30 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36862/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 10:30 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3159
> https://issues.apache.org/jira/browse/MESOS-3159
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We should keep track of how many containers/executors has been
> destroyed/killed due to preemption (due to QoS corrections).
>
>
> Diffs
> -----
>
> src/slave/metrics.hpp 43c8662a211266f358772e55eef374462cb971a0
> src/slave/metrics.cpp ae3a53e8ac2e8e76a6a77fdc7ba55ccaae00781a
> src/slave/slave.cpp 16c403b3ff506461f3dadcfb9f6ee5e66eccb5d7
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
> src/tests/slave_tests.cpp e086817a980cf88f8ff8d539e9791051f35dfbac
>
> Diff: https://reviews.apache.org/r/36862/diff/
>
>
> Testing
> -------
>
> make check with new checks in OversubscriptionTest.QoSCorrectionKill
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 36862: Added metric for number of preempted
executors.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36862/
-----------------------------------------------------------
(Updated July 27, 2015, 3:30 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-3159
https://issues.apache.org/jira/browse/MESOS-3159
Repository: mesos
Description
-------
We should keep track of how many containers/executors has been
destroyed/killed due to preemption (due to QoS corrections).
Diffs (updated)
-----
src/slave/metrics.hpp 43c8662a211266f358772e55eef374462cb971a0
src/slave/metrics.cpp ae3a53e8ac2e8e76a6a77fdc7ba55ccaae00781a
src/slave/slave.cpp 16c403b3ff506461f3dadcfb9f6ee5e66eccb5d7
src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
src/tests/slave_tests.cpp e086817a980cf88f8ff8d539e9791051f35dfbac
Diff: https://reviews.apache.org/r/36862/diff/
Testing (updated)
-------
make check with new checks in OversubscriptionTest.QoSCorrectionKill
Thanks,
Niklas Nielsen