[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

["Joel Bernstein (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545488#comment-17545488 ] 

Joel Bernstein commented on SOLR-14699:
---------------------------------------

I tested out the PR and it looks good. I generated some errors and stack traces and its clear that the scope of this work didn't effect errors and stacks. The log parsing in SolrLogPostTool has been simplified quite a bit as well.

> Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-14699
>                 URL: https://issues.apache.org/jira/browse/SOLR-14699
>             Project: Solr
>          Issue Type: Improvement
>          Components: logging
>            Reporter: David Smiley
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String with simple space-separated pairs with name=value.  However, it does no escaping/encoding, and as-such a value might itself contain spaces and equals.  This is a problem if these logs are being parsed, and we'd like to ensure we do so correctly.  Note that SolrLogPostTool (aka "postlogs") parses these logs.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org