[jira] [Updated] (HIVE-123) refactor DDL code (both DDLWork and DDLTask)

["Phabricator (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-123:
-----------------------------

    Attachment: HIVE-123.D1803.1.patch

dmitrys requested code review of "HIVE-123 [jira] refactor DDL code (both DDLWork and DDLTask)".
Reviewers: kevinwilfong, JIRA

  [Task #675564] Throw a Hive error if we're in strict mode and a the types of a partition comparison do not match.

  Added the check in strict mode.

  Task ID: #675564

  It might be good to break DDLTask into separate tasks. The abstract class DDLWork can have various subclasses:
  showTablesWork, DescribeTableWork etc. and a separate task for each of them. This will make them completely independent.

TEST PLAN
  Run the negative test select_partcol_diff_types.q

  Revert Plan: revert the changes of the commit

  Tags: hive

REVISION DETAIL
  https://reviews.facebook.net/D1803

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java
  ql/src/test/queries/clientnegative/select_partcol_diff_types.q
  ql/src/test/results/clientnegative/select_partcol_diff_types.q.out

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/3843/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> refactor DDL code (both DDLWork and DDLTask)
> --------------------------------------------
>
>                 Key: HIVE-123
>                 URL: https://issues.apache.org/jira/browse/HIVE-123
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Ashutosh Chauhan
>              Labels: cleanup, refactoring
>         Attachments: HIVE-123.D1485.1.patch, HIVE-123.D1485.2.patch, HIVE-123.D1803.1.patch, hive-123.patch
>
>
> It might be good to break DDLTask into separate tasks. The abstract class DDLWork can have various subclasses:
> showTablesWork, DescribeTableWork etc. and a separate task for each of them. This will make them completely independent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira