You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/10 11:32:07 UTC

[GitHub] [druid] LakshSingla commented on a change in pull request #11902: Add dimension partitioningType to metrics to track usage of different partitioning schemes

LakshSingla commented on a change in pull request #11902:
URL: https://github.com/apache/druid/pull/11902#discussion_r746500822



##########
File path: core/src/main/java/org/apache/druid/timeline/partition/ShardSpec.java
##########
@@ -134,4 +140,29 @@ default boolean sharePartitionSpace(PartialShardSpec partialShardSpec)
   {
     return !partialShardSpec.useNonRootGenerationPartitionSpace();
   }
+
+  /**
+   * ShardSpec type names.
+   */
+  interface Type

Review comment:
       nit: Access modifier




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org