You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2009/10/29 23:37:59 UTC
[jira] Commented: (PIG-1059) FINDBUGS: remaining Bad practice +
Multithreaded correctness Warning
[ https://issues.apache.org/jira/browse/PIG-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771665#action_12771665 ]
Hadoop QA commented on PIG-1059:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423606/PIG-1059.patch
against trunk revision 831051.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs warnings.
-1 release audit. The applied patch generated 308 release audit warnings (more than the trunk's current 301 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/32/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/32/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/32/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/32/console
This message is automatically generated.
> FINDBUGS: remaining Bad practice + Multithreaded correctness Warning
> --------------------------------------------------------------------
>
> Key: PIG-1059
> URL: https://issues.apache.org/jira/browse/PIG-1059
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1059.patch
>
>
> IS Inconsistent synchronization of org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodConfDir; locked 66% of time
> IS Inconsistent synchronization of org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodProcess; locked 80% of time
> IS Inconsistent synchronization of org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.remoteHodConfDir; locked 88% of time
> IS Inconsistent synchronization of org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POStream.initialized; locked 50% of time
> UG org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getAggregate() is unsynchronized, org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setAggregate(boolean) is synchronized
> UG org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getReporter() is unsynchronized, org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setReporter(Reporter) is synchronized
> BC Equals method for org.apache.pig.builtin.PigStorage assumes the argument is of type PigStorage
> BC Equals method for org.apache.pig.impl.streaming.StreamingCommand$HandleSpec assumes the argument is of type StreamingCommand$HandleSpec
> DP org.apache.pig.data.BagFactory.getInstance() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block
> DP org.apache.pig.data.TupleFactory.getInstance() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block
> DP org.apache.pig.impl.PigContext.createCl(String) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block
> DP org.apache.pig.impl.util.JarManager.createCl(String, PigContext) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block
> Eq org.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer defines compareTo(DistinctDataBag$DistinctDataBagIterator$TContainer) and uses Object.equals()
> Eq org.apache.pig.data.SingleTupleBag defines compareTo(Object) and uses Object.equals()
> Eq org.apache.pig.data.SortedDataBag$SortedDataBagIterator$PQContainer defines compareTo(SortedDataBag$SortedDataBagIterator$PQContainer) and uses Object.equals()
> Eq org.apache.pig.data.TargetedTuple defines compareTo(Object) and uses Object.equals()
> HE org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan defines equals and uses Object.hashCode()
> HE org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator defines equals and uses Object.hashCode()
> HE org.apache.pig.builtin.BinaryStorage defines equals and uses Object.hashCode()
> HE org.apache.pig.builtin.BinStorage defines equals and uses Object.hashCode()
> HE org.apache.pig.builtin.PigStorage defines equals and uses Object.hashCode()
> HE org.apache.pig.data.InternalSortedBag$DefaultComparator defines equals and uses Object.hashCode()
> HE org.apache.pig.data.NonSpillableDataBag defines equals and uses Object.hashCode()
> HE org.apache.pig.data.SortedDataBag$DefaultComparator defines equals and uses Object.hashCode()
> HE org.apache.pig.impl.streaming.StreamingCommand$HandleSpec defines equals and uses Object.hashCode()
> Nm org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit) doesn't override method in superclass because parameter type org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit doesn't match superclass parameter type org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> Nm org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit) doesn't override method in superclass because parameter type org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit doesn't match superclass parameter type org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
> RV org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.deleteLocalDir(File) ignores exceptional return value of java.io.File.delete()
> RV org.apache.pig.backend.local.datastorage.LocalPath.delete() ignores exceptional return value of java.io.File.delete()
> RV org.apache.pig.data.DefaultAbstractBag.clear() ignores exceptional return value of java.io.File.delete()
> RV org.apache.pig.data.DefaultAbstractBag.finalize() ignores exceptional return value of java.io.File.delete()
> RV org.apache.pig.impl.io.FileLocalizer.create(String, boolean, PigContext) ignores exceptional return value of java.io.File.mkdirs()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.