You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/09 10:28:00 UTC
[GitHub] [iceberg-docs] gaborkaszab opened a new pull request, #187: Update the how-to-release page with findings after being a release manager
gaborkaszab opened a new pull request, #187:
URL: https://github.com/apache/iceberg-docs/pull/187
There are some obsolete steps, plus some that weren't on the list like revapi to run on the new version, etc.
Also I found some useful information on different Apache projects how-to-release page that I figured would be beneficial to have here, like include in the voting mail some info about binding vs non-binding votes, when the vote passes, etc. Also added an introduction part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1121606050
##########
landing-page/content/common/how-to-release.md:
##########
@@ -192,11 +212,15 @@ This release includes important changes that I should have summarized here, but
Please download, verify, and test.
-Please vote in the next 72 hours.
+Please vote in the next 72 hours. (Weekends excluded)
Review Comment:
@Fokko Yeah, that's a good idea, but then there might be confusion with how to count the national holidays that aren't the same in each country :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152042983
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project. [Here](https://www.apache.org/legal/release-policy.html) you can read about the release process in general for an Apache project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting [votes](/how-to-release/#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release.
+* PMC: Gives binding votes on the release.
Review Comment:
nit: a bit awkward to only put binding vote as a bullet point. Can we move that as a part of the last sentence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1100198419
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting votes, announcing the release and so on. Doesn't have to be a committer but then should find a committer who helps out with some of the steps.
+* The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release.
Review Comment:
Thanks for the observation! There is already a section that describes what voting is, also has a link to the Apache voting page. I added a link from this part of the doc to the voting section.
Additionally, I added a link for the apache release-policy page as well.
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting votes, announcing the release and so on. Doesn't have to be a committer but then should find a committer who helps out with some of the steps.
Review Comment:
Thanks, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] ajantha-bhat commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1086946962
##########
landing-page/content/common/how-to-release.md:
##########
@@ -192,11 +212,15 @@ This release includes important changes that I should have summarized here, but
Please download, verify, and test.
-Please vote in the next 72 hours.
+Please vote in the next 72 hours. (Weekends excluded)
Review Comment:
Apache guidelines
> Release votes SHOULD remain open for at least 72 hours.
https://www.apache.org/legal/release-policy.html#release-approval
https://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152045633
##########
landing-page/content/common/how-to-release.md:
##########
@@ -235,6 +265,8 @@ svn add apache-iceberg-<VERSION>
svn ci -m 'Iceberg: Add release <VERSION>'
```
+Note, the above step requires PMC privileges to execute.
Review Comment:
I think we only need committer level privilege?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#issuecomment-1488227303
Hey @Fokko @RussellSpitzer @rdblue ,
I believe I've addressed all the review comment. Would you mind taking another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on pull request #187: Update the how-to-release page with findings after being a release manager
Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#issuecomment-1370875120
Hey, Happy New Year, @Fokko and @ajantha-bhat!
Could you please take another look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152936288
##########
landing-page/content/common/how-to-release.md:
##########
@@ -69,6 +81,14 @@ Set it as remote with name `apache` for release if it is not already set up.
## Creating a release candidate
+### Initiate a discussion about the release with the community
+
+This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+
+The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+
+Note, creating a milestone in github requires a committer. However, a non-committer can assign tasks to a milestone if added to the list of collaborators in [.asf.yaml](https://github.com/apache/iceberg/blob/master/.asf.yaml)
Review Comment:
Sure, added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152047473
##########
landing-page/content/common/how-to-release.md:
##########
@@ -235,6 +265,8 @@ svn add apache-iceberg-<VERSION>
svn ci -m 'Iceberg: Add release <VERSION>'
```
+Note, the above step requires PMC privileges to execute.
Review Comment:
Also we can use `!!!Note` syntax to format the text
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152934717
##########
landing-page/content/common/how-to-release.md:
##########
@@ -235,6 +265,8 @@ svn add apache-iceberg-<VERSION>
svn ci -m 'Iceberg: Add release <VERSION>'
```
+Note, the above step requires PMC privileges to execute.
Review Comment:
In fact the step to push the release to SVN requires PMC privileges. I was working together with @Fokko on this and even him didn't have enough permissions so we had to include a PMC member to execute this.
I tried this "!!! Note" syntax, but honestly don't get the point :) This just writes the same in the page. Do I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1100101504
##########
landing-page/content/common/how-to-release.md:
##########
@@ -192,11 +212,15 @@ This release includes important changes that I should have summarized here, but
Please download, verify, and test.
-Please vote in the next 72 hours.
+Please vote in the next 72 hours. (Weekends excluded)
Review Comment:
I think it's up to the project to set the length as long as it's at least 3 days. At Impala we found it practical to make this "working days" as people in the community were quite inactive on the weekends for instance and a vote started on Friday usually didn't get enough attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] Fokko commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1121568877
##########
landing-page/content/common/how-to-release.md:
##########
@@ -192,11 +212,15 @@ This release includes important changes that I should have summarized here, but
Please download, verify, and test.
-Please vote in the next 72 hours.
+Please vote in the next 72 hours. (Weekends excluded)
Review Comment:
Should we then change this into working days? I think de-facto is already the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152042357
##########
landing-page/content/common/how-to-release.md:
##########
@@ -69,6 +81,14 @@ Set it as remote with name `apache` for release if it is not already set up.
## Creating a release candidate
+### Initiate a discussion about the release with the community
+
+This step can be useful to gather ongoing patches that the community thinks should be in the upcoming release.
+
+The communication can be started via a [DISCUSS] mail on the dev@ channel and the desired tickets can be added to the github milestone of the next release.
+
+Note, creating a milestone in github requires a committer. However, a non-committer can assign tasks to a milestone if added to the list of collaborators in [.asf.yaml](https://github.com/apache/iceberg/blob/master/.asf.yaml)
Review Comment:
We should also mention that the release status is discussed during each community sync meeting. Release manager should join the meeting to report status and discuss any release blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] nastra commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1086933656
##########
landing-page/content/common/how-to-release.md:
##########
@@ -192,11 +212,15 @@ This release includes important changes that I should have summarized here, but
Please download, verify, and test.
-Please vote in the next 72 hours.
+Please vote in the next 72 hours. (Weekends excluded)
Review Comment:
I'm not sure whether that's actually true or not. Might be good to have a definitive answer whether this should be `working days` vs `the next 3 days`.
@rdblue I remember you mentioned something around this a while ago, so maybe we could clarify it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152044624
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project. [Here](https://www.apache.org/legal/release-policy.html) you can read about the release process in general for an Apache project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting [votes](/how-to-release/#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release.
+* PMC: Gives binding votes on the release.
Review Comment:
actually, looks like we also explain binding and non-binding in L221, should we just remove it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1152908927
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project. [Here](https://www.apache.org/legal/release-policy.html) you can read about the release process in general for an Apache project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting [votes](/how-to-release/#voting), announcing the release and so on. Requires the assistance of a committer for some steps.
+* The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release.
+* PMC: Gives binding votes on the release.
Review Comment:
Also non-binding votes are mentioned here. The basic idea for this section was to list the roles related to the release process. The community in general can give non-binding votes while the PMC can give binding ones.
Yes, this is also mentioned in L221 but please note, that it is a sample text for the email to be sent out for voting. So in my opinion there is a need to mention the types of voting here and on L221 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on pull request #187: Update the how-to-release page with findings after being a release manager
Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#issuecomment-1344127711
cc @Fokko @ajantha-bhat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] RussellSpitzer commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1087992589
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting votes, announcing the release and so on. Doesn't have to be a committer but then should find a committer who helps out with some of the steps.
Review Comment:
```Doesn't have to be a committer but then should find a committer who helps out with some of the steps.```
Maybe
```Requires the assistance of a committer for some steps.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "gaborkaszab (via GitHub)" <gi...@apache.org>.
gaborkaszab commented on PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#issuecomment-1489928203
> mostly looks good to me, just a few nits!
Thanks for taking a look, @jackye1995 ! I believe I have addressed/answered all of your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 merged pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] RussellSpitzer commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1088003719
##########
landing-page/content/common/how-to-release.md:
##########
@@ -21,6 +21,18 @@ disableSidebar: true
- limitations under the License.
-->
+## Introduction
+
+This page walks you through the release process of the Iceberg project.
+
+Decisions about releases are made by three groups:
+
+* Release Manager: Does the work of creating the release, signing it, counting votes, announcing the release and so on. Doesn't have to be a committer but then should find a committer who helps out with some of the steps.
+* The community: Performs the discussion of whether it is the right time to create a release and what that release should contain. The community can also cast non-binding votes on the release.
Review Comment:
We should probably define what "votes on the release" means in this context. May be fine to just link to the Apache Docs
https://www.apache.org/foundation/voting.html
Which has a lot more through information
And https://www.apache.org/legal/release-policy.html
as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1045663147
##########
landing-page/content/common/how-to-release.md:
##########
@@ -222,6 +246,12 @@ Therefore, the release candidate is passed/rejected.
After the release vote has passed, you need to release the last candidate's artifacts.
+But note that releasing the artifacts should happen around the same time the new docs are released
Review Comment:
I wouldn't put the section to prepare the doc PRs before the voting is finished. You might end up preparing the PRs multiple times if more RCs are needed to pass the vote. I figured the ideal place to prepare the doc PRs is after the vote has passes and we started working on finishing the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] ajantha-bhat commented on a diff in pull request #187: Update the how-to-release page with findings after being a release manager
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on code in PR #187:
URL: https://github.com/apache/iceberg-docs/pull/187#discussion_r1044318909
##########
landing-page/content/common/how-to-release.md:
##########
@@ -222,6 +246,12 @@ Therefore, the release candidate is passed/rejected.
After the release vote has passed, you need to release the last candidate's artifacts.
+But note that releasing the artifacts should happen around the same time the new docs are released
Review Comment:
This step can be just
"Publish the new documentation and site docs which were prepared [here](/prepare-the-site-documentation-PRs).
At line 178, we can have the section called.
`### prepare the site documentation PRs`
Note that releasing the artifacts should happen around the same time the new docs are released
so make sure the [documentation changes](/how-to-release/#documentation-release)
are prepared when going through the below steps and keep the PRs open for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org