You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2018/07/18 06:00:58 UTC
[isis] 09/09: ISIS-1810: cleans up use of Lombok annotations on
SimpleObject
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
commit 50500e2b7d5cd676bccdd29a626e17ac41c26d09
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Wed Jul 18 08:00:30 2018 +0200
ISIS-1810: cleans up use of Lombok annotations on SimpleObject
removes @Getter and @Setter from class level, introduces too much noise elsewhere and too easy to not notice.
---
.../main/java/domainapp/modules/simple/dom/impl/SimpleObject.java | 5 -----
1 file changed, 5 deletions(-)
diff --git a/example/application/simpleapp/module-simple/src/main/java/domainapp/modules/simple/dom/impl/SimpleObject.java b/example/application/simpleapp/module-simple/src/main/java/domainapp/modules/simple/dom/impl/SimpleObject.java
index ed8963d..80acf29 100644
--- a/example/application/simpleapp/module-simple/src/main/java/domainapp/modules/simple/dom/impl/SimpleObject.java
+++ b/example/application/simpleapp/module-simple/src/main/java/domainapp/modules/simple/dom/impl/SimpleObject.java
@@ -39,7 +39,6 @@ import org.apache.isis.applib.services.repository.RepositoryService;
import org.apache.isis.applib.services.title.TitleService;
import domainapp.modules.simple.dom.types.Name;
-import lombok.AccessLevel;
@javax.jdo.annotations.PersistenceCapable(identityType=IdentityType.DATASTORE, schema = "simple")
@javax.jdo.annotations.DatastoreIdentity(strategy=javax.jdo.annotations.IdGeneratorStrategy.IDENTITY, column="id")
@@ -47,7 +46,6 @@ import lombok.AccessLevel;
@javax.jdo.annotations.Unique(name="SimpleObject_name_UNQ", members = {"name"})
@DomainObject(auditing = Auditing.ENABLED)
@DomainObjectLayout() // causes UI events to be triggered
-@lombok.Getter @lombok.Setter
@lombok.RequiredArgsConstructor
public class SimpleObject implements Comparable<SimpleObject> {
@@ -103,17 +101,14 @@ public class SimpleObject implements Comparable<SimpleObject> {
// -- injected services
@javax.inject.Inject
@javax.jdo.annotations.NotPersistent
- @lombok.Getter(AccessLevel.NONE) @lombok.Setter(AccessLevel.NONE)
RepositoryService repositoryService;
@javax.inject.Inject
@javax.jdo.annotations.NotPersistent
- @lombok.Getter(AccessLevel.NONE) @lombok.Setter(AccessLevel.NONE)
TitleService titleService;
@javax.inject.Inject
@javax.jdo.annotations.NotPersistent
- @lombok.Getter(AccessLevel.NONE) @lombok.Setter(AccessLevel.NONE)
MessageService messageService;
//endregion