You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/01 18:19:22 UTC
[GitHub] [tvm] lhutton1 opened a new pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
lhutton1 opened a new pull request #9417:
URL: https://github.com/apache/tvm/pull/9417
BYOC requires `keep_quantized_weight` be set to true when converting PyTorch models using `from_torch`. Setting this to be True when importing a model using TVMC.
cc @leandron @masahi @ekalda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957394404
I think "from_pytorch API" is tested seperately. We can add a test to see if PyTorchFrontend.load(...) issues the correct a call to "from_pytorch" API. @lhutton1 WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957253147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 edited a comment on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 edited a comment on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957423867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957245926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957163711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 edited a comment on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 edited a comment on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957423867
We can check that the output of converting a quantized model has either `int8` or `uint8` weights, rather than `float32` - which I think would be slightly better. I did look at this, but it looks like there's issues running PyTorch TVMC tests in CI - #7455, so it will need further investigation. Edit: It looks related to #9362, so I'll look at re-enabling the test once CI is updated and adding a similar quantized version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957163711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957245926
If this was merged in before the release branch was cut - can we back port this fix for 0.8 ? It seems pretty inappropriate to let something like this not get fixed in the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm merged pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #9417:
URL: https://github.com/apache/tvm/pull/9417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957245926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 edited a comment on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 edited a comment on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957423867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957253147
cc @junrushao1994 would it be possible to include this fix in the v8.0 draft?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957423867
We can check that the output of converting a quantized model has either `int8` or `uint8` weights, rather than `float32`. I did look at this, but it looks like there's issues running PyTorch TVMC tests in CI - #7455, so it will need further investigation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm merged pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #9417:
URL: https://github.com/apache/tvm/pull/9417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957163711
Thanks @masahi @lhutton1 . This is merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm merged pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #9417:
URL: https://github.com/apache/tvm/pull/9417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 edited a comment on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 edited a comment on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957423867
We can check that the output of converting a quantized model has either `int8` or `uint8` weights, rather than `float32` - which I think would be slightly better. I did look at this, but it looks like there's issues running PyTorch TVMC tests in CI - #7455, so it will need further investigation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957356155
Further should there be a test for this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9417: [TVMC] Keep quantized weights when importing PyTorch model
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9417:
URL: https://github.com/apache/tvm/pull/9417#issuecomment-957253147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org