You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Mihai Chira <mi...@gmail.com> on 2015/06/07 18:41:26 UTC
Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields
with all data types
If anyone wants to help with a few lines of documentation (for
ComplexSortField), that would help a lot. Otherwise I'll get round to
it in a couple of weeks.
Same for more unit testing (see FLEX-34852[1], which has a unit test
called FLEX_34852_Tests). For instance, xml sorting is not currently
tested, nor is sorting alongside filtering.
[1] https://issues.apache.org/jira/browse/FLEX-34852
On 7 June 2015 at 18:27, Mihai Chira (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/FLEX-34883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Mihai Chira resolved FLEX-34883.
> --------------------------------
> Resolution: Fixed
>
> This has been resolved as part of FLEX-34852.
>
>> Sort correctly by complex fields with all data types
>> ----------------------------------------------------
>>
>> Key: FLEX-34883
>> URL: https://issues.apache.org/jira/browse/FLEX-34883
>> Project: Apache Flex
>> Issue Type: Sub-task
>> Components: Spark: Sort and SortField
>> Affects Versions: Apache Flex 4.14.1
>> Reporter: Mihai Chira
>> Assignee: Mihai Chira
>> Fix For: Apache Flex 4.15.0
>>
>>
>> The first step is to make sure that ListCollectionView can sort correctly by complex properties.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields
with all data types
Posted by Mihai Chira <mi...@gmail.com>.
Yep, agreed, and done.
On 2 March 2016 at 09:18, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
>> Justin, maybe you noticed that I finally got round to integrating your
>> unit tests into the framework,
>
> Yep thanks for that.
>
>> and that they uncovered the bug with
>> setItemAt() in a filtered collection with duplicate items inside.
>> removeItemAt() has the same problem, of course.
>
> I did have a look at fixing them but it’s complex and would have performance implications. IMO I’d just disable those tests, that way they are documented if anyone looks. The old(er) Adobe Flex framework has the same bugs so it not a regression.
>
> Thanks,
> Justin
Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields with all data types
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Justin, maybe you noticed that I finally got round to integrating your
> unit tests into the framework,
Yep thanks for that.
> and that they uncovered the bug with
> setItemAt() in a filtered collection with duplicate items inside.
> removeItemAt() has the same problem, of course.
I did have a look at fixing them but it’s complex and would have performance implications. IMO I’d just disable those tests, that way they are documented if anyone looks. The old(er) Adobe Flex framework has the same bugs so it not a regression.
Thanks,
Justin
Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields
with all data types
Posted by Mihai Chira <mi...@gmail.com>.
Justin, maybe you noticed that I finally got round to integrating your
unit tests into the framework, and that they uncovered the bug with
setItemAt() in a filtered collection with duplicate items inside.
removeItemAt() has the same problem, of course. Namely, they're
FLEX-35039 and FLEX-17045.
Any ideas how to solve this issue?
On 8 June 2015 at 10:48, Mihai Chira <mi...@gmail.com> wrote:
> Thanks, I'll take a look in a while, when I work on this again.
>
> On 8 June 2015 at 00:43, Justin Mclean <ju...@classsoftware.com> wrote:
>> Hi,
>>
>> This may be of some help:
>> http://people.apache.org/~jmclean/ArrayCollectionTests.fxp
>>
>> Justin
Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields
with all data types
Posted by Mihai Chira <mi...@gmail.com>.
Thanks, I'll take a look in a while, when I work on this again.
On 8 June 2015 at 00:43, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
> This may be of some help:
> http://people.apache.org/~jmclean/ArrayCollectionTests.fxp
>
> Justin
Re: [jira] [Resolved] (FLEX-34883) Sort correctly by complex fields with all data types
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
This may be of some help:
http://people.apache.org/~jmclean/ArrayCollectionTests.fxp
Justin