You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/30 19:14:13 UTC
[GitHub] [pulsar] merlimat commented on a change in pull request #4407: Fix
remove pending acks in Key_Shared subscription
merlimat commented on a change in pull request #4407: Fix remove pending acks in Key_Shared subscription
URL: https://github.com/apache/pulsar/pull/4407#discussion_r289132295
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##########
@@ -334,7 +334,7 @@ void messageAcked(CommandAck ack) {
return;
}
- if (subType == SubType.Shared) {
+ if (subType == SubType.Shared || subType == SubType.Key_Shared) {
Review comment:
Since this is being checked multiple times, we could have a static method to check for this condition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services