You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/11/04 22:58:06 UTC
Review Request 15214: Re-deprecated 'webui_hostname' as optional (from
required).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15214/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
We still need to set the 'webui_hostname' field for now in order for
interoperating with code that expects it to be required (e.g., a slave
on an older release). After another deprecation cycle we can either
remove this field entirely or just keep it around as an artifact so
that we don't reuse the ID.
Diffs
-----
include/mesos/mesos.proto d45ee5ea1287f925332968b7247b21f72ba38b13
src/common/type_utils.hpp 90149d9b44ac252282f061d27f65b4e14bd3f7d4
src/slave/slave.cpp 74bcbecb8240a4de21efd103be744869a81c72ce
Diff: https://reviews.apache.org/r/15214/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 15214: Re-deprecated 'webui_hostname' as optional (from
required).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15214/#review28143
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/15214/#comment54755>
s/slave/executor/
- Vinod Kone
On Nov. 4, 2013, 9:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15214/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 9:58 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We still need to set the 'webui_hostname' field for now in order for
> interoperating with code that expects it to be required (e.g., a slave
> on an older release). After another deprecation cycle we can either
> remove this field entirely or just keep it around as an artifact so
> that we don't reuse the ID.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto d45ee5ea1287f925332968b7247b21f72ba38b13
> src/common/type_utils.hpp 90149d9b44ac252282f061d27f65b4e14bd3f7d4
> src/slave/slave.cpp 74bcbecb8240a4de21efd103be744869a81c72ce
>
> Diff: https://reviews.apache.org/r/15214/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>