You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/26 12:35:37 UTC

[GitHub] [solr] gerlowskija commented on pull request #1127: SOLR-16477 Collection RENAME api creates broken alias

gerlowskija commented on PR #1127:
URL: https://github.com/apache/solr/pull/1127#issuecomment-1291967379

   > if the starting point for the stream is a Map<>, the 'merge keys' part where it checks for collisions(a, b) -> IllegalStateException would never be possible
   
   In this case, I think that's true - we're not really "mapping" the keys in the sense this method allows, we're just taking them unmodified from an existing Map.  I can imagine cases where the merge/collection function would be necessary, but it looks redundant here to me 🤷 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org