You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by kinow <gi...@git.apache.org> on 2018/02/27 03:12:03 UTC

[GitHub] logging-log4j2 pull request #155: Fix typo in documentation

GitHub user kinow opened a pull request:

    https://github.com/apache/logging-log4j2/pull/155

    Fix typo in documentation

    Hello, found while updating a legacy project from log4j1 to log4j2, and reading the docs (which are great, by the way, a life saver. Thanks!)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/logging-log4j2 patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit c8261a5b1997c121f9416d693e60dac050c2719f
Author: Bruno P. Kinoshita <ki...@...>
Date:   2018-02-27T03:11:43Z

    Fix typo in documentation
    
    Hello, found while updating a legacy project from log4j1 to log4j2, and reading the docs (which are great, by the way, a life saver. Thanks!)

----


---

[GitHub] logging-log4j2 issue #155: Fix typo in documentation

Posted by kinow <gi...@git.apache.org>.

Github user kinow commented on the issue:

    https://github.com/apache/logging-log4j2/pull/155
  
    Roger thay. Exatly the same as OpenNLP. Will follow it if I find any other issues.


---

[GitHub] logging-log4j2 issue #155: Fix typo in documentation

Posted by remkop <gi...@git.apache.org>.

Github user remkop commented on the issue:

    https://github.com/apache/logging-log4j2/pull/155
  
    Good catch, thanks!


---

[GitHub] logging-log4j2 issue #155: Fix typo in documentation

Posted by remkop <gi...@git.apache.org>.

Github user remkop commented on the issue:

    https://github.com/apache/logging-log4j2/pull/155
  
    Thanks for the pull request! This is now merged into master and the release-2.x branch.
    
    Please verify and close the associated JIRA ticket: https://issues.apache.org/jira/browse/LOG4J2-2273



---

[GitHub] logging-log4j2 issue #155: Fix typo in documentation

Posted by remkop <gi...@git.apache.org>.

Github user remkop commented on the issue:

    https://github.com/apache/logging-log4j2/pull/155
  
    You’re welcome!
    If you really want to dot the i‘s and cross the t’s, prefix the commit message with the JIRA number. That’s the convention we use to keep our git history clean and easy to search. Thanks again for the contribution!


---

[GitHub] logging-log4j2 pull request #155: Fix typo in documentation

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/155


---

[GitHub] logging-log4j2 issue #155: Fix typo in documentation

Posted by kinow <gi...@git.apache.org>.

Github user kinow commented on the issue:

    https://github.com/apache/logging-log4j2/pull/155
  
    Thanks for merging it so quickly, and for creating the JIRA ticket. My next ticket will accompany a ticket :-)


---