You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/03 18:22:24 UTC
[kudu-CR] KUDU-1938 Make UTF-8 truncation faster pt 1
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14353 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 1
......................................................................
Patch Set 10:
(5 comments)
Sorry, I had reviewed this a week or two ago but forgot to publish.
http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc
File src/kudu/util/char_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc@39
PS9, Line 39: Env* env = Env::Default();
KuduTest has an env_ member.
http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc@82
PS9, Line 82: ptr = Truncate(data_ascii_, 10549, &result); ASSERT_EQ(10549, result.size());
Nit: indentation. And wrapping.
http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc@87
PS9, Line 87: Slice test_data;
:
: test_data = "aaaa\xf3";
Combine?
http://gerrit.cloudera.org:8080/#/c/14353/10/src/kudu/util/char_util-test.cc
File src/kudu/util/char_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/14353/10/src/kudu/util/char_util-test.cc@50
PS10, Line 50: std::
using
http://gerrit.cloudera.org:8080/#/c/14353/7/src/kudu/util/char_util.cc
File src/kudu/util/char_util.cc:
http://gerrit.cloudera.org:8080/#/c/14353/7/src/kudu/util/char_util.cc@32
PS7, Line 32: while (num_bytes < size) {
> Done
Oh so 8-byte alignment isn't important? Interesting.
--
To view, visit http://gerrit.cloudera.org:8080/14353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebb98e18a3619029d9b0bc224c7dead89a3d7374
Gerrit-Change-Number: 14353
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 03 Dec 2019 18:22:24 +0000
Gerrit-HasComments: Yes