You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/07 19:04:40 UTC
[GitHub] [spark] abellina commented on a change in pull request #24419:
[SPARK-25719] : Search functionality in datatables in stages page should
search over formatted data rather than the raw data
abellina commented on a change in pull request #24419: [SPARK-25719] : Search functionality in datatables in stages page should search over formatted data rather than the raw data
URL: https://github.com/apache/spark/pull/24419#discussion_r281786916
##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala
##########
@@ -189,32 +189,41 @@ private[v1] class StagesResource extends BaseAppResource {
val taskMetricsContainsValue = (task: TaskData) => task.taskMetrics match {
case None => false
case Some(metrics) =>
- (containsValue(task.taskMetrics.get.executorDeserializeTime)
- || containsValue(task.taskMetrics.get.executorRunTime)
- || containsValue(task.taskMetrics.get.jvmGcTime)
- || containsValue(task.taskMetrics.get.resultSerializationTime)
- || containsValue(task.taskMetrics.get.memoryBytesSpilled)
- || containsValue(task.taskMetrics.get.diskBytesSpilled)
- || containsValue(task.taskMetrics.get.peakExecutionMemory)
- || containsValue(task.taskMetrics.get.inputMetrics.bytesRead)
+ (containsValue(UIUtils.formatDuration(task.taskMetrics.get.executorDeserializeTime))
+ || containsValue(UIUtils.formatDuration(task.taskMetrics.get.executorRunTime))
+ || containsValue(UIUtils.formatDuration(task.taskMetrics.get.jvmGcTime))
+ || containsValue(UIUtils.formatDuration(task.taskMetrics.get.resultSerializationTime))
+ || containsValue(UIUtils.formatBytes(task.taskMetrics.get.memoryBytesSpilled))
+ || containsValue(UIUtils.formatBytes(task.taskMetrics.get.diskBytesSpilled))
+ || containsValue(UIUtils.formatBytes(task.taskMetrics.get.peakExecutionMemory))
+ || containsValue(UIUtils.formatBytes(task.taskMetrics.get.inputMetrics.bytesRead))
|| containsValue(task.taskMetrics.get.inputMetrics.recordsRead)
- || containsValue(task.taskMetrics.get.outputMetrics.bytesWritten)
+ || containsValue(UIUtils.formatBytes(task.taskMetrics.get.outputMetrics.bytesWritten))
|| containsValue(task.taskMetrics.get.outputMetrics.recordsWritten)
- || containsValue(task.taskMetrics.get.shuffleReadMetrics.fetchWaitTime)
+ || containsValue(UIUtils.formatDuration(
+ task.taskMetrics.get.shuffleReadMetrics.fetchWaitTime))
+ || containsValue(UIUtils.formatBytes(
+ task.taskMetrics.get.shuffleReadMetrics.remoteBytesRead))
+ || containsValue(UIUtils.formatBytes(
+ task.taskMetrics.get.shuffleReadMetrics.localBytesRead +
+ task.taskMetrics.get.shuffleReadMetrics.remoteBytesRead))
|| containsValue(task.taskMetrics.get.shuffleReadMetrics.recordsRead)
- || containsValue(task.taskMetrics.get.shuffleWriteMetrics.bytesWritten)
+ || containsValue(UIUtils.formatBytes(
+ task.taskMetrics.get.shuffleWriteMetrics.bytesWritten))
|| containsValue(task.taskMetrics.get.shuffleWriteMetrics.recordsWritten)
- || containsValue(task.taskMetrics.get.shuffleWriteMetrics.writeTime))
+ || containsValue(UIUtils.formatDuration(
+ task.taskMetrics.get.shuffleWriteMetrics.writeTime / 1000000)))
Review comment:
I stand corrected, thanks @pgandhi999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org