You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2010/03/26 17:46:12 UTC
Re: svn commit: r927953 - in /commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser:
ASTIntegerLiteral.java ASTStringLiteral.java
On 26/03/2010, henrib@apache.org <he...@apache.org> wrote:
> Author: henrib
> Date: Fri Mar 26 16:29:54 2010
> New Revision: 927953
>
> URL: http://svn.apache.org/viewvc?rev=927953&view=rev
> Log:
> Per Sebb's recommendation, made those final.
Actually, I meant that the field
private Integer literal;
should be final, not the classes.
I have no view on whether the classes should be final or not.
> Modified:
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java
>
> Modified: commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java
> URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java?rev=927953&r1=927952&r2=927953&view=diff
> ==============================================================================
> --- commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java (original)
> +++ commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java Fri Mar 26 16:29:54 2010
> @@ -16,7 +16,7 @@
> */
> package org.apache.commons.jexl2.parser;
>
> -public class ASTIntegerLiteral extends JexlNode implements JexlNode.Literal<Integer> {
> +public final class ASTIntegerLiteral extends JexlNode implements JexlNode.Literal<Integer> {
> /** The type literal value. */
> private Integer literal;
>
>
> Modified: commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java
> URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java?rev=927953&r1=927952&r2=927953&view=diff
> ==============================================================================
> --- commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java (original)
> +++ commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java Fri Mar 26 16:29:54 2010
> @@ -16,7 +16,7 @@
> */
> package org.apache.commons.jexl2.parser;
>
> -public class ASTStringLiteral extends JexlNode implements JexlNode.Literal<String> {
> +public final class ASTStringLiteral extends JexlNode implements JexlNode.Literal<String> {
>
> public ASTStringLiteral(int id) {
> super(id);
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r927953 - in /commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser:
ASTIntegerLiteral.java ASTStringLiteral.java
Posted by sebb <se...@gmail.com>.
On 26/03/2010, henrib <he...@apache.org> wrote:
>
> The ctor is called by javacc generated code and I cant think of a way to make
> it pass the proper argument.
>
Sorry, misread the patch - I thought the field was set in the ctor,
but the field is actually just a cache variable.
> --
> View this message in context: http://n4.nabble.com/Re-svn-commit-r927953-in-commons-proper-jexl-trunk-src-main-java-org-apache-commons-jexl2-parser-ASTa-tp1692511p1692580.html
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r927953 - in
/commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser:
ASTIntegerLiteral.java ASTStringLiteral.java
Posted by henrib <he...@apache.org>.
The ctor is called by javacc generated code and I cant think of a way to make
it pass the proper argument.
--
View this message in context: http://n4.nabble.com/Re-svn-commit-r927953-in-commons-proper-jexl-trunk-src-main-java-org-apache-commons-jexl2-parser-ASTa-tp1692511p1692580.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org