You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by Diwaker Gupta <di...@maginatics.com> on 2011/07/08 00:01:58 UTC

Review Request: Remove unused include in generated C++ code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1034/
-----------------------------------------------------------

Review request for Thrift.


Summary
-------

Remove unused include in generated C++ code.

When using cob_style with the CPP generator, the compiler adds an include for TTransportUtils. This include doesn't seem to be used anywhere and creates an unnecessary dependency. It also complicates compiling Thrift generated code on other platforms.


Diffs
-----

  /compiler/cpp/src/generate/t_cpp_generator.cc 1143615 

Diff: https://reviews.apache.org/r/1034/diff


Testing
-------

make check in lib/cpp


Thanks,

Diwaker

Re: Review Request: Remove unused include in generated C++ code

Posted by Diwaker Gupta <di...@maginatics.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1034/
-----------------------------------------------------------

(Updated 2011-07-08 20:06:30.944891)


Review request for Thrift.


Summary
-------

Remove unused include in generated C++ code.

When using cob_style with the CPP generator, the compiler adds an include for TTransportUtils. This include doesn't seem to be used anywhere and creates an unnecessary dependency. It also complicates compiling Thrift generated code on other platforms.


This addresses bug TRIFT-1233.
    https://issues.apache.org/jira/browse/TRIFT-1233


Diffs
-----

  /compiler/cpp/src/generate/t_cpp_generator.cc 1143615 

Diff: https://reviews.apache.org/r/1034/diff


Testing
-------

make check in lib/cpp


Thanks,

Diwaker