You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by haydenmarchant <gi...@git.apache.org> on 2014/06/25 15:36:52 UTC

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

GitHub user haydenmarchant opened a pull request:

    https://github.com/apache/accumulo/pull/10

    ACCUMULO-2942 Fixes ShardedTableDistributionFormatterTest on all JVMs

    ACCUMULO-2942 Fixes ShardedTableDistributionFormatterTest on all JVMs
    
    ShardedTableDistributionFormatterTest.testAggregate() was failing due
    to inconsistency in order to stats that were returned in the getStats()
    method. This is due to the fact that the structure that holds the stats is
    a HashMap.
    
    The test was changed so that it does not assert that elements exists
    at certain location in results, but rather it now checks that elements
    exist in the list. The test was also slightly broadened so that it
    checks that tuples of (day, count) exist in list.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/haydenmarchant/accumulo ACCUMULO-2942

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 72a95412c756463bce99e8610377a018a28e8a7d
Author: haydenmarchant <ha...@gmail.com>
Date:   2014-06-25T13:19:31Z

    ACCUMULO-2942 Fixes ShardedTableDistributionFormatterTest on all JVMs
    
    ShardedTableDistributionFormatterTest.testAggregate() was failing due
    to inconsistency in order to stats that were returned in the getStats()
    method. This is due to the fact that the structure that holds the stats is
    a HashMap.
    
    The test was changed so that it does not assert that elements exists
    at certain location in results, but rather it now checks that elements
    exist in the list. The test was also slightly broadened so that it
    checks that tuples of (day, count) exist in list.

commit af70970ef5602a6f489f7fe2259dffca0edbd901
Author: haydenmarchant <ha...@gmail.com>
Date:   2014-06-25T13:34:12Z

    ACCUMULO-2942 Fixes ShardedTableDistributionFormatterTest on all JVMs
    
    ShardedTableDistributionFormatterTest.testAggregate() was failing due
    to inconsistency in order to stats that were returned in the getStats()
    method. This is due to the fact that the structure that holds the stats is
    a HashMap.
    
    The test was changed so that it does not assert that elements exists
    at certain location in results, but rather it now checks that elements
    exist in the list. The test was also slightly broadened so that it
    checks that tuples of (day, count) exist in list.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by haydenmarchant <gi...@git.apache.org>.
Github user haydenmarchant commented on the pull request:

    https://github.com/apache/accumulo/pull/10#issuecomment-47521353
  
    formatting has been fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by busbey <gi...@git.apache.org>.
Github user busbey commented on the pull request:

    https://github.com/apache/accumulo/pull/10#issuecomment-47118043
  
    Please format the files according to the [style guide][1] (notably you aren't consistently using 2 spaces per indent level)
    
    [1]: http://accumulo.apache.org/source.html#coding-practices


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by busbey <gi...@git.apache.org>.
Github user busbey commented on the pull request:

    https://github.com/apache/accumulo/pull/10#issuecomment-47563841
  
    this has been pushed and merged forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by busbey <gi...@git.apache.org>.
Github user busbey commented on the pull request:

    https://github.com/apache/accumulo/pull/10#issuecomment-47118595
  
    I've assigned this to you over on the jira for [ACCUMULO-2942][1]. You're listed as a contributor in jira now, which should allow you to adopt tickets on your own.
    
    When working on things, please assign the jira to yourself. When you open a PR, please change the jira status to "Patch Submitted".
    
    [1]: https://issues.apache.org/jira/browse/ACCUMULO-2942


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by busbey <gi...@git.apache.org>.
Github user busbey commented on the pull request:

    https://github.com/apache/accumulo/pull/10#issuecomment-47117689
  
    please squash commits


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/accumulo/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] accumulo pull request: ACCUMULO-2942 Fixes ShardedTableDistributio...

Posted by busbey <gi...@git.apache.org>.
Github user busbey commented on the pull request:

    https://github.com/apache/accumulo/pull/10#issuecomment-47538043
  
    Looks good. I'm in the process of rebasing to the current branch and pushing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---