[GitHub] [maven-surefire] sman-81 commented on a change in pull request #453: [SUREFIRE-1994] Upgrade and configure javacc-maven-plugin, add src/generated/java to .gitignore

[GitBox <gi...@apache.org>]

sman-81 commented on a change in pull request #453:
URL: https://github.com/apache/maven-surefire/pull/453#discussion_r795038397



##########
File path: surefire-grouper/pom.xml
##########
@@ -32,18 +32,53 @@
   <name>Maven Surefire Test-Grouping Support</name>
   <description>Maven Surefire Test-Grouping Support</description>
 
+  <properties>
+    <javacc.version>7.0.10</javacc.version>
+    <generated.sources.dir>${project.basedir}/src/generated/java</generated.sources.dir>
+  </properties>
+
   <build>
     <plugins>
       <plugin>
-        <groupId>org.codehaus.mojo</groupId>
+        <groupId>org.javacc.plugin</groupId>
         <artifactId>javacc-maven-plugin</artifactId>
-        <version>2.6</version>
+        <version>3.0.3</version>
         <executions>
           <execution>
             <id>javacc</id>
             <goals>
               <goal>javacc</goal>
             </goals>
+            <configuration>
+              <sourceDirectory>${project.basedir}/src/main/javacc</sourceDirectory>

Review comment:
       I like things to be obvious and explicit. Devs not familiar with the workings of this plugin will be able to understand better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org