[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models

[GitBox <gi...@apache.org>]

bgawrych commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r732027694



##########
File path: src/operator/subgraph/dnnl/dnnl_post_quantize_property.h
##########
@@ -56,7 +56,7 @@ class SgDNNLPostQuantizeSelector : public SubgraphSelector {
 
   bool Select(const nnvm::Node& n) override {
     if (n.op() && support_requantize_fusion_op_name.count(n.op()->name)) {
-      if (n.op()->name == "_sg_onednn_conv" || n.op()->name == "_sg_mkldnn_conv") {
+      if (n.op()->name == "_sg_onednn_conv") {

Review comment:
       n.op() == Op::Get("...") should deal with both comparisions in single one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org