[jira] [Commented] (YARN-4263) Capacity scheduler 60%-40% formatting floating point issue

["Shane Kumpf (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618062#comment-15618062 ] 

Shane Kumpf commented on YARN-4263:
-----------------------------------

I validated this is still an issue in trunk. The patch applies cleanly and fixes the problem.
Overall the patch looks good. One change is that it seems {{TypeConverter#scheduleInfo}} could be made private. Can you update the patch with that change?

> Capacity scheduler 60%-40% formatting floating point issue
> ----------------------------------------------------------
>
>                 Key: YARN-4263
>                 URL: https://issues.apache.org/jira/browse/YARN-4263
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.7.1
>            Reporter: Adrian Kalaszi
>            Priority: Trivial
>              Labels: easyfix, oct16-easy
>         Attachments: YARN-4263.001.patch, YARN-4263.002.patch, YARN-4263.003.patch, YARN-4263.004.patch, YARN-4263.005.patch
>
>
> If capacity scheduler is set with two queues to 60% and 40% capacity, due to a java float floating representation issue
> {code}
> > hadoop queue -list
> ======================
> Queue Name : default 
> Queue State : running 
> Scheduling Info : Capacity: 40.0, MaximumCapacity: 100.0, CurrentCapacity: 0.0 
> ======================
> Queue Name : large 
> Queue State : running 
> Scheduling Info : Capacity: 60.000004, MaximumCapacity: 100.0, CurrentCapacity: 0.0 
> {code}
> Because 
> {code} System.err.println((0.6f) * 100); {code}
> results in 60.000004.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org