[GitHub] [spark] ulysses-you commented on a diff in pull request #40952: [SPARK-43281][SQL] Fix concurrent writer does not update file metrics

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on code in PR #40952:
URL: https://github.com/apache/spark/pull/40952#discussion_r1177313799


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/BasicWriteTaskStatsTrackerSuite.scala:
##########
@@ -85,22 +85,23 @@ class BasicWriteTaskStatsTrackerSuite extends SparkFunSuite {
     val missing = new Path(tempDirPath, "missing")
     val tracker = new BasicWriteTaskStatsTracker(conf)
     tracker.newFile(missing.toString)
+    tracker.closeFile(missing.toString)

Review Comment:
   after refactor of https://github.com/apache/spark/pull/32198, one `newFile` should have one `closeFile`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org