[GitHub] [pulsar] merlimat commented on a change in pull request #12168: fix logger number not correct in tests

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168#discussion_r715706532



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -924,7 +924,7 @@ public void validatePoliciesReadOnlyAccess() {
                 throw new RestException(Status.FORBIDDEN, "Broker is forbidden to do read-write operations");
             }
         } catch (Exception e) {
-            log.warn("Unable to fetch read-only policy config {}", e);
+            log.warn("Unable to fetch read-only policy config ", e);

Review comment:
       Though the behavior with or without placeholder is different, and in some cases we really mean to have the placeholder there. eg: 
   
    * With placeholder: only the exception message is printed
    * Without placeholder: the full stacks trace is printed
   
   For common, expected errors we don't want to pollute the logs with lots of stack traces that are not very useful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org