You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (Jira)" <ji...@apache.org> on 2019/11/22 21:38:00 UTC

[jira] [Resolved] (HTTPCORE-613) Add staleConnectionCheckEnabled=true semantic behavior in validateAfterInactivity config

     [ https://issues.apache.org/jira/browse/HTTPCORE-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCORE-613.
----------------------------------------
    Fix Version/s: 5.0-beta11
       Resolution: Fixed

Merged to master.

Oleg

> Add staleConnectionCheckEnabled=true semantic behavior in validateAfterInactivity config
> ----------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-613
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-613
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.4.12
>            Reporter: Peter Frank
>            Priority: Major
>             Fix For: 5.0-beta11
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Between HttpClient 4.4.x and 4.5.x setStaleConnectionCheckEnabled was deprecated in favor of setValidateAfterInactivity.  That's all fine, however, the implementation of setValidateAfterInactivity has no ability to check if a connection is stale all the time.  The closest one can get is 1 ms, and that's unfortunately not short enough in a test environment scenario when a test Http Server is being restarted between Tests to clear out state.
> This is a common issue on the internet for people that use something like Wiremock, the irony is troubleshooting the situation makes it go away (cause logging slows the tests).
> I would suggest making 0 a special value to "turn on" validation all the time.
> With HttpClient 5 removing the old staleConnectionCheckEnabled completely with a piece of what that feature actually did also being removed I fear it will leave me, and perhaps others, in a bit of a lurch.  Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org