You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/07/15 23:59:09 UTC

[GitHub] jerrypeng opened a new pull request #2168: fixing protobuf schema shading issue

jerrypeng opened a new pull request #2168:  fixing protobuf schema shading issue
URL: https://github.com/apache/incubator-pulsar/pull/2168
 
 
   ### Motivation
   
   Currently, when users pull in Pulsar-Client dependency protobuf is shaded thus ProtobufSchema which obviously uses protobuf is needs a users to provided the shaded version of protobuf.  Obviously this is not acceptable as it would be pretty much impossible for the user to do so.
   
   ### Modifications
   
   I moved the all the schema code into a separate module that will use an unshaded version of protobuf so users can freely create their own protobufs and use it with the ProtobufSchema
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services