You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zhouyifan279 (via GitHub)" <gi...@apache.org> on 2023/06/08 11:54:32 UTC
[GitHub] [kyuubi] zhouyifan279 opened a new pull request, #4936: [KYUUBI#4935][Improvement] More than target num of executors may survive after FinalStageResourceManager did kill
zhouyifan279 opened a new pull request, #4936:
URL: https://github.com/apache/kyuubi/pull/4936
### _Why are the changes needed?_
When FinalStageResourceManager chooses executors to be killed, it may add dead executors to the kill list.
This will leave more than target num of executors survived and cause resource waste.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4936: [KYUUBI#4935][Improvement] More than target num of executors may survive after FinalStageResourceManager did kill
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4936: [KYUUBI#4935][Improvement] More than target num of executors may survive after FinalStageResourceManager did kill
URL: https://github.com/apache/kyuubi/pull/4936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zhouyifan279 commented on pull request #4936: [KYUUBI#4935][Improvement] More than target num of executors may survive after FinalStageResourceManager did kill
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #4936:
URL: https://github.com/apache/kyuubi/pull/4936#issuecomment-1582445794
cc @ulysses-you @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4936: [KYUUBI#4935][Improvement] More than target num of executors may survive after FinalStageResourceManager did kill
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4936:
URL: https://github.com/apache/kyuubi/pull/4936#issuecomment-1582479777
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org