You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "khalidmammadov (via GitHub)" <gi...@apache.org> on 2023/04/19 20:05:58 UTC

[GitHub] [spark] khalidmammadov opened a new pull request, #40859: [FOLLOW-UP][SPARK-42437][PYTHON][CONNECT] Storage level proto converters

khalidmammadov opened a new pull request, #40859:
URL: https://github.com/apache/spark/pull/40859

   ### What changes were proposed in this pull request?
   Converters between Proto and StorageLevel to avoid code duplication
   It's follow up from https://github.com/apache/spark/pull/40015
   
   ### Why are the changes needed?
   Code deduplication
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Existing tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] khalidmammadov commented on pull request #40859: [FOLLOW-UP][SPARK-42437][PYTHON][CONNECT] Storage level proto converters

Posted by "khalidmammadov (via GitHub)" <gi...@apache.org>.
khalidmammadov commented on PR #40859:
URL: https://github.com/apache/spark/pull/40859#issuecomment-1515312261

   @ueshin Can you please review? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ueshin closed pull request #40859: [SPARK-42437][CONNECT][PYTHON][FOLLOW-UP] Storage level proto converters

Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin closed pull request #40859: [SPARK-42437][CONNECT][PYTHON][FOLLOW-UP] Storage level proto converters
URL: https://github.com/apache/spark/pull/40859


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ueshin commented on pull request #40859: [SPARK-42437][CONNECT][PYTHON][FOLLOW-UP] Storage level proto converters

Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #40859:
URL: https://github.com/apache/spark/pull/40859#issuecomment-1515339665

   Thanks! merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org