You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/08 17:05:20 UTC
[GitHub] [kafka] rondagostino opened a new pull request, #12396: KAFKA-14051: Create metrics reporters in KRaft remote controllers
rondagostino opened a new pull request, #12396:
URL: https://github.com/apache/kafka/pull/12396
KRaft remote controllers do not yet support dynamic reconfiguration (https://issues.apache.org/jira/browse/KAFKA-14057). Until we implement that, in the meantime we see that the instantiation of the configured metric reporters is actually performed as part of the wiring for dynamic reconfiguration. Since that wiring does not exist yet for KRaft remote controllers, this patch refactors out the instantiation of the metric reporters from the reconfiguration of them and adjusts the controller startup sequence to explicitly instantiate the reporters if the controller is a remote one.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on a diff in pull request #12396: KAFKA-14051: Create metrics reporters in KRaft remote controllers
Posted by GitBox <gi...@apache.org>.
rondagostino commented on code in PR #12396:
URL: https://github.com/apache/kafka/pull/12396#discussion_r917007329
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -744,17 +744,18 @@ class DynamicThreadPool(server: KafkaBroker) extends BrokerReconfigurable {
}
}
-class DynamicMetricsReporters(brokerId: Int, server: KafkaBroker) extends Reconfigurable {
+class DynamicMetricsReporters(brokerId: Int, config: KafkaConfig, metrics: Metrics, clusterId: String) extends Reconfigurable {
Review Comment:
Could potentially leave this signature alone, but it would probably have to change to this when we implement https://issues.apache.org/jira/browse/KAFKA-14057 anyway, so it perhaps doesn't hurt to change it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #12396: KAFKA-14051: Create metrics reporters in KRaft remote controllers
Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12396:
URL: https://github.com/apache/kafka/pull/12396#issuecomment-1191834062
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #12396: KAFKA-14051: Create metrics reporters in KRaft remote controllers
Posted by GitBox <gi...@apache.org>.
cmccabe merged PR #12396:
URL: https://github.com/apache/kafka/pull/12396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #12396: KAFKA-14051: Create metrics reporters in KRaft remote controllers
Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12396:
URL: https://github.com/apache/kafka/pull/12396#issuecomment-1191834126
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org