You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Greg Brown (JIRA)" <ji...@apache.org> on 2010/08/03 17:51:17 UTC
[jira] Created: (PIVOT-583) Add parent to TreeNode/TreeBranch
Add parent to TreeNode/TreeBranch
---------------------------------
Key: PIVOT-583
URL: https://issues.apache.org/jira/browse/PIVOT-583
Project: Pivot
Issue Type: Improvement
Components: wtk
Reporter: Greg Brown
Priority: Minor
Fix For: 2.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-583) Add parent to TreeNode/TreeBranch
Posted by "Todd Volkert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894951#action_12894951 ]
Todd Volkert commented on PIVOT-583:
------------------------------------
Heads up, we used to have this feature way back when Pivot was a JS library, and we removed it for what I want to say was a very good reason (but I can't remember what it was!). Before we add it back, it'd be good to at least know why it was removed the first time and if that reason still applies...
> Add parent to TreeNode/TreeBranch
> ---------------------------------
>
> Key: PIVOT-583
> URL: https://issues.apache.org/jira/browse/PIVOT-583
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Greg Brown
> Priority: Minor
> Fix For: 2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-583) Add parent to TreeNode/TreeBranch
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894959#action_12894959 ]
Greg Brown commented on PIVOT-583:
----------------------------------
I don't remember the reason either, but I don't see any harm in adding it now. org.apache.pivot.xml.Node has a parent Element, which is conceptually similar (Elements can also be used as tree data). Both Element and TreeBranch implement List, which is the actual data model interface; List doesn't define a parent property, but I don't see any reason why implementations of List shouldn't define one. Would you agree?
> Add parent to TreeNode/TreeBranch
> ---------------------------------
>
> Key: PIVOT-583
> URL: https://issues.apache.org/jira/browse/PIVOT-583
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Greg Brown
> Priority: Minor
> Fix For: 2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-583) Add parent to TreeNode/TreeBranch
Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894971#action_12894971 ]
Roger Whitcomb commented on PIVOT-583:
--------------------------------------
FWIW -- every time I've implemented my own Tree data structures they always have had a "parent" link -- makes many things that you have to do in traversing the tree much easier.
> Add parent to TreeNode/TreeBranch
> ---------------------------------
>
> Key: PIVOT-583
> URL: https://issues.apache.org/jira/browse/PIVOT-583
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Greg Brown
> Priority: Minor
> Fix For: 2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIVOT-583) Add parent to TreeNode/TreeBranch
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Brown resolved PIVOT-583.
------------------------------
Assignee: Greg Brown
Resolution: Fixed
> Add parent to TreeNode/TreeBranch
> ---------------------------------
>
> Key: PIVOT-583
> URL: https://issues.apache.org/jira/browse/PIVOT-583
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Greg Brown
> Assignee: Greg Brown
> Priority: Minor
> Fix For: 2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIVOT-583) Add parent to TreeNode/TreeBranch
Posted by "Todd Volkert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894970#action_12894970 ]
Todd Volkert commented on PIVOT-583:
------------------------------------
I can't think of a good reason not to do it, so yeah, I agree. I just hope the ghosts of jslib don't come home to roost ;-)
> Add parent to TreeNode/TreeBranch
> ---------------------------------
>
> Key: PIVOT-583
> URL: https://issues.apache.org/jira/browse/PIVOT-583
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Greg Brown
> Priority: Minor
> Fix For: 2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.