You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2006/11/15 01:48:01 UTC
[VOTE] backport WICKET-68 to 1.2.4
[VOTE] backport WICKET-68 to 1.2.4
Re: Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Johan Compagner <jc...@gmail.com>.
yeah i have seen the fix.
weird then.
johan
On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
>
> well, pull open AbstractBehavior
>
> currently it looks like this
>
> /**
> * @see wicket.behavior.IBehavior#rendered(wicket.Component)
> */
> public final void rendered(final Component component)
> {
> onRendered(component);
> }
>
> it should call cleanup() after onRendered() but that is obviously missing.
>
> -igor
>
>
> On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
> >
> > strange that the project here (that did run on 1.2.3+) don't have any
> > problems until they used 1.3
> >
> > but anyway fine by me.
> >
> > johan
> >
> > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > >
> > > it surfaced in 1.3 but is also broken in 1.2.3, i checked before
> posting
> > > the
> > > vote :)
> > >
> > > -igor
> > >
> > >
> > > On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
> > > >
> > > > fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
> > > >
> > > >
> > > >
> > > > On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
> > > > >
> > > > > +1, but was this also a problem in 1.2.3?
> > > > >
> > > > > Martijn
> > > > >
> > > > > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > > > +1
> > > > > >
> > > > > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > > > >
> > > > > > > [VOTE] backport WICKET-68 to 1.2.4
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket
> > > ">Vote</a>
> > > > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
> > > > > ">Wicket</a>
> > > > > at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff
> > in
> > > > > the World!</a>
> > > > >
> > > >
> > > >
> > >
> > >
> >
> >
>
>
Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Johan Compagner <jc...@gmail.com>.
what kind of changes did i do that broke it?
It could be something like that but i am just curious.
johan
On 11/15/06, Matej Knopp <ma...@knopp.sk> wrote:
>
> Please don't "fix" 1.2.4, unless you are really sure that it's broken. I
> suppose the problem with 1.3 is because it's based on johan's brach,
> which didn't reflect the last changes in 1.2.4 (when it was still 1.x).
> Can this be it?
>
> -Matej
>
> Igor Vaynberg wrote:
> > well, pull open AbstractBehavior
> >
> > currently it looks like this
> >
> > /**
> > * @see wicket.behavior.IBehavior#rendered(wicket.Component)
> > */
> > public final void rendered(final Component component)
> > {
> > onRendered(component);
> > }
> >
> > it should call cleanup() after onRendered() but that is obviously
> missing.
> >
> > -igor
> >
> >
> > On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
> >>
> >> strange that the project here (that did run on 1.2.3+) don't have any
> >> problems until they used 1.3
> >>
> >> but anyway fine by me.
> >>
> >> johan
> >>
> >> On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> >> >
> >> > it surfaced in 1.3 but is also broken in 1.2.3, i checked before
> >> posting
> >> > the
> >> > vote :)
> >> >
> >> > -igor
> >> >
> >> >
> >> > On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
> >> > >
> >> > > fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
> >> > >
> >> > >
> >> > >
> >> > > On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
> >> > > >
> >> > > > +1, but was this also a problem in 1.2.3?
> >> > > >
> >> > > > Martijn
> >> > > >
> >> > > > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> >> > > > > +1
> >> > > > >
> >> > > > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> >> > > > > >
> >> > > > > > [VOTE] backport WICKET-68 to 1.2.4
> >> > > > >
> >> > > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket
> >> > ">Vote</a>
> >> > > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
> >> > > > ">Wicket</a>
> >> > > > at the <a href="http://www.thebeststuffintheworld.com/">Best
> Stuff
> >> in
> >> > > > the World!</a>
> >> > > >
> >> > >
> >> > >
> >> >
> >> >
> >>
> >>
> >
>
>
Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Matej Knopp <ma...@knopp.sk>.
Please don't "fix" 1.2.4, unless you are really sure that it's broken. I
suppose the problem with 1.3 is because it's based on johan's brach,
which didn't reflect the last changes in 1.2.4 (when it was still 1.x).
Can this be it?
-Matej
Igor Vaynberg wrote:
> well, pull open AbstractBehavior
>
> currently it looks like this
>
> /**
> * @see wicket.behavior.IBehavior#rendered(wicket.Component)
> */
> public final void rendered(final Component component)
> {
> onRendered(component);
> }
>
> it should call cleanup() after onRendered() but that is obviously missing.
>
> -igor
>
>
> On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
>>
>> strange that the project here (that did run on 1.2.3+) don't have any
>> problems until they used 1.3
>>
>> but anyway fine by me.
>>
>> johan
>>
>> On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
>> >
>> > it surfaced in 1.3 but is also broken in 1.2.3, i checked before
>> posting
>> > the
>> > vote :)
>> >
>> > -igor
>> >
>> >
>> > On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
>> > >
>> > > fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
>> > >
>> > >
>> > >
>> > > On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
>> > > >
>> > > > +1, but was this also a problem in 1.2.3?
>> > > >
>> > > > Martijn
>> > > >
>> > > > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
>> > > > > +1
>> > > > >
>> > > > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
>> > > > > >
>> > > > > > [VOTE] backport WICKET-68 to 1.2.4
>> > > > >
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket
>> > ">Vote</a>
>> > > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
>> > > > ">Wicket</a>
>> > > > at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff
>> in
>> > > > the World!</a>
>> > > >
>> > >
>> > >
>> >
>> >
>>
>>
>
Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Matej Knopp <ma...@knopp.sk>.
The cleanup is called after model has been detached. This is needed for
the autocomplete behavior to work right.
-Matej
Igor Vaynberg wrote:
> well, pull open AbstractBehavior
>
> currently it looks like this
>
> /**
> * @see wicket.behavior.IBehavior#rendered(wicket.Component)
> */
> public final void rendered(final Component component)
> {
> onRendered(component);
> }
>
> it should call cleanup() after onRendered() but that is obviously missing.
>
> -igor
>
>
> On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
>>
>> strange that the project here (that did run on 1.2.3+) don't have any
>> problems until they used 1.3
>>
>> but anyway fine by me.
>>
>> johan
>>
>> On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
>> >
>> > it surfaced in 1.3 but is also broken in 1.2.3, i checked before
>> posting
>> > the
>> > vote :)
>> >
>> > -igor
>> >
>> >
>> > On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
>> > >
>> > > fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
>> > >
>> > >
>> > >
>> > > On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
>> > > >
>> > > > +1, but was this also a problem in 1.2.3?
>> > > >
>> > > > Martijn
>> > > >
>> > > > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
>> > > > > +1
>> > > > >
>> > > > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
>> > > > > >
>> > > > > > [VOTE] backport WICKET-68 to 1.2.4
>> > > > >
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket
>> > ">Vote</a>
>> > > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
>> > > > ">Wicket</a>
>> > > > at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff
>> in
>> > > > the World!</a>
>> > > >
>> > >
>> > >
>> >
>> >
>>
>>
>
Re: Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Igor Vaynberg <ig...@gmail.com>.
well, pull open AbstractBehavior
currently it looks like this
/**
* @see wicket.behavior.IBehavior#rendered(wicket.Component)
*/
public final void rendered(final Component component)
{
onRendered(component);
}
it should call cleanup() after onRendered() but that is obviously missing.
-igor
On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
>
> strange that the project here (that did run on 1.2.3+) don't have any
> problems until they used 1.3
>
> but anyway fine by me.
>
> johan
>
> On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> >
> > it surfaced in 1.3 but is also broken in 1.2.3, i checked before posting
> > the
> > vote :)
> >
> > -igor
> >
> >
> > On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
> > >
> > > fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
> > >
> > >
> > >
> > > On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
> > > >
> > > > +1, but was this also a problem in 1.2.3?
> > > >
> > > > Martijn
> > > >
> > > > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > > +1
> > > > >
> > > > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > > >
> > > > > > [VOTE] backport WICKET-68 to 1.2.4
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket
> > ">Vote</a>
> > > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
> > > > ">Wicket</a>
> > > > at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff
> in
> > > > the World!</a>
> > > >
> > >
> > >
> >
> >
>
>
Re: Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Johan Compagner <jc...@gmail.com>.
strange that the project here (that did run on 1.2.3+) don't have any
problems until they used 1.3
but anyway fine by me.
johan
On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
>
> it surfaced in 1.3 but is also broken in 1.2.3, i checked before posting
> the
> vote :)
>
> -igor
>
>
> On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
> >
> > fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
> >
> >
> >
> > On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
> > >
> > > +1, but was this also a problem in 1.2.3?
> > >
> > > Martijn
> > >
> > > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > +1
> > > >
> > > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > >
> > > > > [VOTE] backport WICKET-68 to 1.2.4
> > > >
> > > >
> > >
> > >
> > > --
> > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket
> ">Vote</a>
> > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
> > > ">Wicket</a>
> > > at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff in
> > > the World!</a>
> > >
> >
> >
>
>
Re: Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Igor Vaynberg <ig...@gmail.com>.
it surfaced in 1.3 but is also broken in 1.2.3, i checked before posting the
vote :)
-igor
On 11/15/06, Johan Compagner <jc...@gmail.com> wrote:
>
> fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
>
>
>
> On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
> >
> > +1, but was this also a problem in 1.2.3?
> >
> > Martijn
> >
> > On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > +1
> > >
> > > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > > >
> > > > [VOTE] backport WICKET-68 to 1.2.4
> > >
> > >
> >
> >
> > --
> > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket">Vote</a>
> > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
> > ">Wicket</a>
> > at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff in
> > the World!</a>
> >
>
>
Re: Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Johan Compagner <jc...@gmail.com>.
fine by me if we need it, but it surfaced in 1.3 not in 1.2.3..?
On 11/15/06, Martijn Dashorst <ma...@gmail.com> wrote:
>
> +1, but was this also a problem in 1.2.3?
>
> Martijn
>
> On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > +1
> >
> > On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> > >
> > > [VOTE] backport WICKET-68 to 1.2.4
> >
> >
>
>
> --
> <a href="http://www.thebeststuffintheworld.com/vote_for/wicket">Vote</a>
> for <a href="http://www.thebeststuffintheworld.com/stuff/wicket
> ">Wicket</a>
> at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff in
> the World!</a>
>
Re: Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Martijn Dashorst <ma...@gmail.com>.
+1, but was this also a problem in 1.2.3?
Martijn
On 11/15/06, Igor Vaynberg <ig...@gmail.com> wrote:
> +1
>
> On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
> >
> > [VOTE] backport WICKET-68 to 1.2.4
>
>
--
<a href="http://www.thebeststuffintheworld.com/vote_for/wicket">Vote</a>
for <a href="http://www.thebeststuffintheworld.com/stuff/wicket">Wicket</a>
at the <a href="http://www.thebeststuffintheworld.com/">Best Stuff in
the World!</a>
Re: [VOTE] backport WICKET-68 to 1.2.4
Posted by Igor Vaynberg <ig...@gmail.com>.
+1
On 11/14/06, Igor Vaynberg <ig...@gmail.com> wrote:
>
> [VOTE] backport WICKET-68 to 1.2.4