[GitHub] [solr] bruno-roustant commented on pull request #1215: DocRouter: strengthen abstraction

[GitBox <gi...@apache.org>]

bruno-roustant commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1361142463

   @noblepaul I don't fully understand your point RE _"Introducing a new type of Router needs more reviews"_.
   To me this PR does not add a new type of DocRouter, as it is centered around CompositeIdRouter. It makes it clearer that only CompositeIdRouter is supported for split operations in SplitOp, SolrIndexSplitter, MigrateCmd. I see no new code, only some refactoring to move key parsing logic inside CompositeIdRouter. Do I miss something?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org