You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by rebol0x6c <no...@github.com> on 2020/06/16 09:18:10 UTC
[apache/incubator-teaclave] fix sgx sdk path. (#357)
## Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [ ] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [ ] If you've changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-teaclave/pull/357
-- Commit Summary --
* fix sgx sdk path.
-- File Changes --
M docker/teaclave-rt.ubuntu-1804.Dockerfile (2)
-- Patch Links --
https://github.com/apache/incubator-teaclave/pull/357.patch
https://github.com/apache/incubator-teaclave/pull/357.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/357
Re: [apache/incubator-teaclave] fix sgx sdk path. (#357)
Posted by rebol0x6c <no...@github.com>.
make all path consistent done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/357#issuecomment-645412987
Re: [apache/incubator-teaclave] fix sgx sdk path. (#357)
Posted by Mingshen Sun <no...@github.com>.
Thanks for the catch. I found that for other docker files, we are using `/opt`. Can you change to `/opt` to make all consistent?
https://github.com/apache/incubator-teaclave/blob/5d1cfabedd68b3e715bdc3e9c83843902a94f1ea/docker/build.ubuntu-1804.sgx-2.9.1.Dockerfile#L47-L49
https://github.com/apache/incubator-teaclave/blob/5d1cfabedd68b3e715bdc3e9c83843902a94f1ea/docker/build.ubuntu-1804.sgx-dcap-1.6.Dockerfile#L49-L51
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/357#issuecomment-644911299
Re: [apache/incubator-teaclave] fix sgx sdk path. (#357)
Posted by Mingshen Sun <no...@github.com>.
Merged #357 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/357#event-3454671866