You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/04/27 10:53:19 UTC
[GitHub] [spark] itholic opened a new pull request, #40975: [SPARK-43306][PYTHON] Migrate `ValueError` from Spark SQL types into error class
itholic opened a new pull request, #40975:
URL: https://github.com/apache/spark/pull/40975
### What changes were proposed in this pull request?
This PR proposes to migrate all `ValueError` from Spark SQL types into error class.
### Why are the changes needed?
To improve PySpark error
### Does this PR introduce _any_ user-facing change?
No API changes, only error improvement.
### How was this patch tested?
This existing CI should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40975: [SPARK-43306][PYTHON] Migrate `ValueError` from Spark SQL types into error class
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40975:
URL: https://github.com/apache/spark/pull/40975#issuecomment-1535626787
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40975: [SPARK-43306][PYTHON] Migrate `ValueError` from Spark SQL types into error class
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40975: [SPARK-43306][PYTHON] Migrate `ValueError` from Spark SQL types into error class
URL: https://github.com/apache/spark/pull/40975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43306][PYTHON] Migrate `ValueError` from Spark SQL types into error class [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40975:
URL: https://github.com/apache/spark/pull/40975#discussion_r1464254305
##########
python/pyspark/sql/types.py:
##########
@@ -1952,7 +1970,10 @@ def verify_nullability(obj: Any) -> bool:
if nullable:
return True
else:
- raise ValueError(new_msg("This field is not nullable, but got None"))
Review Comment:
You can't remove `new_msg` here ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org