You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/04 00:13:44 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #16981: [BEAM-14009] Set 'sdk_harness_container_images' property for Dataflow Prime - Java SDK

kennknowles commented on a change in pull request #16981:
URL: https://github.com/apache/beam/pull/16981#discussion_r819167304



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -1418,7 +1418,13 @@ static EnvironmentInfo create(String environmentId, String containerUrl) {
 
   static void configureSdkHarnessContainerImages(
       DataflowPipelineOptions options, RunnerApi.Pipeline pipelineProto, Job newJob) {
-    if (useUnifiedWorker(options)) {
+
+    boolean isDataflowPrimeJob =
+        (options.getDataflowServiceOptions() != null
+            && options.getDataflowServiceOptions().contains("enable_prime"));

Review comment:
       The intention behind `--dataflow_service_options` is to have a flag that the SDK sort of promises not to inspect, though...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org