You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/23 10:48:04 UTC
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #57: [FLINK-26791] Finish projection push down for table store
JingsongLi commented on a change in pull request #57:
URL: https://github.com/apache/flink-table-store/pull/57#discussion_r833115393
##########
File path: flink-table-store-kafka/src/main/java/org/apache/flink/table/store/kafka/KafkaLogDeserializationSchema.java
##########
@@ -85,22 +101,50 @@ public RowData deserialize(ConsumerRecord<byte[], byte[]> record) {
}
@Override
- public void deserialize(ConsumerRecord<byte[], byte[]> record, Collector<RowData> out)
+ public void deserialize(
+ ConsumerRecord<byte[], byte[]> record, Collector<RowData> underCollector)
Review comment:
Avoid being misused, we should use new `collector`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org