You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/21 18:14:48 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new issue #11368: [table chart] raw records SELECT ALL option is broken
graceguo-supercat opened a new issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368
Table chart's select all option is broken.
#### Screenshots
If applicable, add screenshots to help explain your problem.
### Environment
lastest master branch
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-726190498
on it @graceguo-supercat @zuzana-vej
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-718400403
any idea which PR caused it? i dont recall anyone touched this area lately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-726193402
@junlincc I don't think I did any changes to those Select buttons, but I'm on it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-713770476
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-729823109
I looked through the changes and after all it was a regression caused by my PR from September - https://github.com/apache/incubator-superset/pull/10889. I refactored a `for… of… loop` to `forEach` in order to fix ESLint errors - however, there was a `return` statement inside. In the old version, it returned from the whole function and after refactor, it returned only from `forEach`, causing the outer function to keep running and finally breaking the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-728633636
> @junlincc I don't think I did any changes to those Select buttons, but I'm on it!
i dont think so either! then the next person who touched this area was Jesse maybe 😆 but thank you @kgabryje for the fix.🙏
tested, all good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc closed issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-725862508
@junlincc it looks like this issue is still there. I think it could have been caused by earlier redesigns on the Explore page - similar as what caused https://github.com/apache/incubator-superset/issues/11379 or https://github.com/apache/incubator-superset/issues/11404 (just a guess, it's also ~2-3 weeks old issue, so discovered around the same time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on issue #11368: [table chart] raw records SELECT ALL option is broken
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #11368:
URL: https://github.com/apache/incubator-superset/issues/11368#issuecomment-726190498
on it. seems like @kgabryje touched this area recently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org