You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/04 10:49:07 UTC

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/
-----------------------------------------------------------

(Updated 四月 4, 2016, 8:49 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Removed HOST_PATH volume source.


Summary (updated)
-----------------

Ignored the DOCKER_VOLUME volume source.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
-------

Ignored the DOCKER_VOLUME volume source.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45373/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/#review126977
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 471)
<https://reviews.apache.org/r/45373/#comment190108>

    VLOG(1) << "Ignored the 'DOCKER_VOLUME' volume source";


- Gilbert Song


On April 4, 2016, 1:49 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45373/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 1:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored the DOCKER_VOLUME volume source.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
> 
> Diff: https://reviews.apache.org/r/45373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/#review127137
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 471)
<https://reviews.apache.org/r/45373/#comment190276>

    I think this message not enough. Usually I would like to know this ignore for which container or which executor.


- haosdent huang


On April 4, 2016, 8:49 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45373/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 8:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored the DOCKER_VOLUME volume source.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
> 
> Diff: https://reviews.apache.org/r/45373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/#review128939
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 471 - 472)
<https://reviews.apache.org/r/45373/#comment192390>

    let quote the containerId:
    
    ```
          VLOG(1) << "Ignored the 'DOCKER_VOLUME' volume source for container '"
                  << containerId << "'";
    ```


- Gilbert Song


On April 13, 2016, 2:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45373/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored the DOCKER_VOLUME volume source.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
> 
> Diff: https://reviews.apache.org/r/45373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/#review129598
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 19, 2016, 2:52 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45373/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 2:52 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored the DOCKER_VOLUME volume source.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
> 
> Diff: https://reviews.apache.org/r/45373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/
-----------------------------------------------------------

(Updated 四月 19, 2016, 2:52 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Ignored the DOCKER_VOLUME volume source.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45373/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/
-----------------------------------------------------------

(Updated 四月 15, 2016, 6:37 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Ignored the DOCKER_VOLUME volume source.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45373/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/#review129021
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (lines 469 - 470)
<https://reviews.apache.org/r/45373/#comment192486>

    Can we just check `volume.has_source()` only? It does not support anyway.


- Jie Yu


On April 13, 2016, 9:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45373/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:26 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored the DOCKER_VOLUME volume source.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 
> 
> Diff: https://reviews.apache.org/r/45373/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45373: Ignored the DOCKER_VOLUME volume source.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/
-----------------------------------------------------------

(Updated 四月 13, 2016, 9:26 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Ignored the DOCKER_VOLUME volume source.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45373/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu