You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/17 11:25:49 UTC
[GitHub] [incubator-nuttx] zouboan opened a new pull request, #7335: arch/sparc add support of spin_lock for LEON3 and LEON4
zouboan opened a new pull request, #7335:
URL: https://github.com/apache/incubator-nuttx/pull/7335
## Summary
1、Add support of spin_lock for LEON3 and LEON4
2、Build CMN_SRCS in common directory to keep up with other arch
## Impact
sparc
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7335: arch/sparc add support of spin_lock for LEON3 and LEON4
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7335:
URL: https://github.com/apache/incubator-nuttx/pull/7335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7335: arch/sparc add support of spin_lock for LEON3 and LEON4
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7335:
URL: https://github.com/apache/incubator-nuttx/pull/7335#discussion_r997049839
##########
arch/sparc/include/spinlock.h:
##########
@@ -44,12 +44,10 @@
/* The Type of a spinlock.
*
- * This must be a uint32_ becaue it will be set using S32C1I instruction.
- * That instruction atomically stores to a memory location only if its
- * current value is the expected one. The state register (SCOMPARE1) is
- * used to provide the additional comparison operand. Some implementations
- * also have a state register (ATOMCTL) for further control of the atomic
- * operation in cache and on the PIF bus.
+ * This must be a uint32_ becaue it will be set using CASA instruction.
Review Comment:
```suggestion
* This must be a uint32_ because it will be set using CASA instruction.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org