[jira] [Resolved] (THRIFT-2987) TProtocol should return NSString directly rather than by reference to appease ARC

["James E. King III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III resolved THRIFT-2987.
---------------------------------------
       Resolution: Won't Do
         Assignee: James E. King III
    Fix Version/s: 1.0

As support for the older cocoa compiler and library have been removed (see THRIFT-4719), all of the issues in Jira related to that code have also been removed.  For legacy cocoa support you can use version 0.12.0 - everyone is expected to move to swift if they want to use the next release of Thrift.

> TProtocol should return NSString directly rather than by reference to appease ARC
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-2987
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2987
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Cocoa - Library
>            Reporter: Jeremy W. Sherman
>            Assignee: James E. King III
>            Priority: Major
>             Fix For: 1.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As currently written, the compiler gripes like so:
> {code}
> thrift/lib/cocoa/src/protocol/TBinaryProtocol.m:161:55: warning: method parameter of type 'NSString *__autoreleasing *' with no explicit ownership [-Wexplicit-ownership-type]
> - (void) readMessageBeginReturningName: (NSString **) name
>                                                       ^
> {code}
> Annotating for ownership might make non-ARC builds unhappy, but since there is only one object being returned by reference, this and similar methods can just be changed to return the name directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)