You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "agingade (GitHub)" <gi...@apache.org> on 2019/01/08 00:04:41 UTC

[GitHub] [geode] agingade opened pull request #3055: GEODE-6247: Added suspected exception to ignore list

GEODE-6247: Added suspected exception to ignore list

The changes are similar to the commit made with GEODE-6046 (exact same suspect message).


Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [Y] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [Y] Is your initial contribution a single, squashed commit?

- [Y] Does `gradlew build` run cleanly?

- [NA] Have you written or updated unit tests to verify your changes?

- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@gemzdude 

[ Full content available at: https://github.com/apache/geode/pull/3055 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3055: GEODE-6247: Added suspected exception to ignore list

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
I think it would be better to change the product to handle this jdk bug (see: https://bugs.openjdk.java.net/browse/JDK-8207200). Kirk had an idea of how to do that. Basically when VMStats50.refresh calls getHeapMemoryUsage catch IllegalArgumentException, log something (once?), and then do the remainder of the refresh method. This prevents us from updating some stats but at least by catching the exception we would do the other stats. A user might use this jdk so it seems like it is worth us handling this unexpected exception.

[ Full content available at: https://github.com/apache/geode/pull/3055 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade closed pull request #3055: GEODE-6247: Added suspected exception to ignore list

Posted by "agingade (GitHub)" <gi...@apache.org>.
[ pull request closed by agingade ]

[ Full content available at: https://github.com/apache/geode/pull/3055 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on issue #3055: GEODE-6247: Added suspected exception to ignore list

Posted by "agingade (GitHub)" <gi...@apache.org>.
This will be addressed as part of GEODE-6253

[ Full content available at: https://github.com/apache/geode/pull/3055 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org