[jira] [Commented] (TAP5-1628) Have Submit documentation explicitly state when the disabled attribute is evaluated

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098617#comment-13098617 ] 

Hudson commented on TAP5-1628:
------------------------------

Integrated in tapestry-trunk-freestyle #506 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/506/])
    Fixed TAP5-1628 (Have Submit documentation explicitly state when the disabled attribute is evaluated), javadoc changes only.

bobharner : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165938
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/base/AbstractField.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java


> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
>                 Key: TAP5-1628
>                 URL: https://issues.apache.org/jira/browse/TAP5-1628
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 5.3
>            Reporter: Steve Eynon
>            Assignee: Bob Harner
>            Priority: Trivial
>              Labels: submit
>             Fix For: 5.3
>
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira