[GitHub] [echarts] linghaoSu commented on a diff in pull request #18604: fix(pie): display empty circle correctly

["linghaoSu (via GitHub)" <gi...@apache.org>]

linghaoSu commented on code in PR #18604:
URL: https://github.com/apache/echarts/pull/18604#discussion_r1193916681


##########
src/chart/pie/PieView.ts:
##########
@@ -259,7 +260,21 @@ class PieView extends ChartView {
             group.remove(this._emptyCircleSector);
         }
         // when all data are filtered, show lightgray empty circle
-        if (data.count() === 0 && seriesModel.get('showEmptyCircle')) {
+        // when data sum is zero and showEmptyCircle is true
+        // and roseType is not area, show empty circle
+        const isNeedShowEmptyCircle = (

Review Comment:
   Sorry, I didn't notice this pr, I misunderstood the meaning of this attribute, I will close this pr and the related issue. also I found this [issue](https://github.com/apache/echarts/issues/16117) solves my problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org