You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/05/14 17:53:04 UTC
Review Request: CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api
should also create usage events for updating new default network
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11156/
-----------------------------------------------------------
Review request for cloudstack and mice xia.
Description
-------
When we call UpdateDefaultNicForVirtualMachine we should call appropriate usage events as well for updating information related to default nic for proper usage calculation.
Added 4 usage events : 2 for network.offerings.remove and 2 for network.offerings.assign
Events are : network.offerings.assign for new nic to be made default, network.offerings.remove for removal of non-default
network.offerings.assign for old default nic to be made non default and network.offerings.remove for removal of default.
This addresses bug 2130.
Diffs
-----
server/src/com/cloud/vm/UserVmManagerImpl.java 0f6adc0
Diff: https://reviews.apache.org/r/11156/diff/
Testing
-------
Tested manually.
Rat build passed.
Rebased to latest master.
Thanks,
Saksham Srivastava
Re: Review Request: CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api
should also create usage events for updating new default network
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11156/#review20637
-----------------------------------------------------------
Commit e26081731898e2b3de53fdfb9f58d6fdb017f09f in branch refs/heads/master from Mice Xia <mi...@tcloudcomputing.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e260817 ]
CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api should also create usage events for updating new default network
Signed-off-by: Mice Xia <mi...@tcloudcomputing.com>
- ASF Subversion and Git Services
On May 14, 2013, 3:53 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11156/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 3:53 p.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> When we call UpdateDefaultNicForVirtualMachine we should call appropriate usage events as well for updating information related to default nic for proper usage calculation.
> Added 4 usage events : 2 for network.offerings.remove and 2 for network.offerings.assign
> Events are : network.offerings.assign for new nic to be made default, network.offerings.remove for removal of non-default
> network.offerings.assign for old default nic to be made non default and network.offerings.remove for removal of default.
>
>
> This addresses bug 2130.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java 0f6adc0
>
> Diff: https://reviews.apache.org/r/11156/diff/
>
>
> Testing
> -------
>
> Tested manually.
> Rat build passed.
> Rebased to latest master.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request: CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api
should also create usage events for updating new default network
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11156/#review20636
-----------------------------------------------------------
Ship it!
Ship It!
- mice xia
On May 14, 2013, 3:53 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11156/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 3:53 p.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> When we call UpdateDefaultNicForVirtualMachine we should call appropriate usage events as well for updating information related to default nic for proper usage calculation.
> Added 4 usage events : 2 for network.offerings.remove and 2 for network.offerings.assign
> Events are : network.offerings.assign for new nic to be made default, network.offerings.remove for removal of non-default
> network.offerings.assign for old default nic to be made non default and network.offerings.remove for removal of default.
>
>
> This addresses bug 2130.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java 0f6adc0
>
> Diff: https://reviews.apache.org/r/11156/diff/
>
>
> Testing
> -------
>
> Tested manually.
> Rat build passed.
> Rebased to latest master.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request: CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api
should also create usage events for updating new default network
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11156/#review21183
-----------------------------------------------------------
Commit 62413eec1067ab5d92977fab93a2fc88d4247bb0 in branch refs/heads/master from Mice Xia <mi...@tcloudcomputing.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=62413ee ]
CLOUDSTACK-2130: Fix resource_name for old NIC ID
Signed-off-by: Mice Xia <mi...@tcloudcomputing.com>
- ASF Subversion and Git Services
On May 14, 2013, 3:53 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11156/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 3:53 p.m.)
>
>
> Review request for cloudstack and mice xia.
>
>
> Description
> -------
>
> When we call UpdateDefaultNicForVirtualMachine we should call appropriate usage events as well for updating information related to default nic for proper usage calculation.
> Added 4 usage events : 2 for network.offerings.remove and 2 for network.offerings.assign
> Events are : network.offerings.assign for new nic to be made default, network.offerings.remove for removal of non-default
> network.offerings.assign for old default nic to be made non default and network.offerings.remove for removal of default.
>
>
> This addresses bug 2130.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java 0f6adc0
>
> Diff: https://reviews.apache.org/r/11156/diff/
>
>
> Testing
> -------
>
> Tested manually.
> Rat build passed.
> Rebased to latest master.
>
>
> Thanks,
>
> Saksham Srivastava
>
>