You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/08/16 02:23:10 UTC

[GitHub] spark pull request #22113: [SPARK-25126] Lazily create Reader for orc files

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22113#discussion_r210462023
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileOperator.scala ---
    @@ -70,7 +70,7 @@ private[hive] object OrcFileOperator extends Logging {
           hdfsPath.getFileSystem(conf)
         }
     
    -    listOrcFiles(basePath, conf).iterator.map { path =>
    +    listOrcFiles(basePath, conf).view.map { path =>
    --- End diff --
    
    Do you mean `collectFirst` actually traverse `iterator` entirely?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org